Ibm Serveraid Problem with 2.4.25
Quoted 30 lines · Marcelo Tosatti
Quoted 10 lines · Chuck Lever
hi marcelo-
your "fix" will break readahead again for NFS. with the ">=" as you propose, the read ahead code will never be able to read the last page of the file as a coalesced read, it will always be a separate 4KB read.
the problem is not the readahead code, it is the driver code that tries to read beyond the end of the device. my change merely exposed this misbehavior.
Quoted 6 lines
so there is a broken assumption somewhere about how the index of the last page of a file/device is computed. i think it is a problem when the file ends exactly on a page boundary.
alain, if you don't use the NFS client, marcelo's fix should work just fine for you. but i believe that in general it is incorrect.
Okey, most drivers do no exhibit this problem indeed.
We should try to fix the problematic drivers, then.
If we can't do it easily and in a straightforward manner, I'm afraid we will have to undo your change because even if the "read end beyond of device" accesses are harmless (are they really harmless?), they must fixed.
Agreed?
Quoted 7 lines
I'll take a look at them later today, but I'm no expert, so help is very appreciated.
We know that these have problems:
- Promise ATA
- ips (serveraid)
Also seeing this with the siimage driver with a 3112 SATA chipset.
Signature · 3 lines
Alan. "One must never be purposelessnessnesslessness."