syncppp broken - how to fix?
In 2.6.0-test8 a patch from [email protected] was applied to drivers/net/wan/syncppp.c which breaks syncppp when used with some wan drivers:
drivers/net/wan/cosa.cdrivers/net/wan/hostess_sv11.cdrivers/net/wan/wanpipe_multppp.cdrivers/char/synclink.cdrivers/char/synclinkmp.cdrivers/char/pcmcia/synclink_cs.c
The problem is the addition of a BUG_ON() line in sppp_attach() which imposes the new requirement that the net device priv member be initialized *before* calling sppp_attach().
The priv member is not actually used in sppp_attach(). The BUG_ON line does a sanity check which touches priv member, which is not set prior to calling sppp_attach() by the drivers listed above.
So should all of the WAN drivers be changed to accomodate this new requirement (which does not seem to serve a purpose) ?
Or should the BUG_ON line be removed from syncppp.c to return it to the original convention?
It seems odd to add a sanity check for a member that is not used and is not set. It also seems counter productive to modify multiple drivers to set this value to accomodate the new sanity check since that value is still not used in sppp_attach.
Signature · 2 lines
Paul Fulghum [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 20040303114906.1a4027da@dell_ss3.pdx.osdl.net
Quoted 2 lines · Stephen Hemminger
That assert can go, it is a left over from the conversion of the wan devices to use
alloc_netdev.
OK
Quoted 2 lines
The whole ppp structure layering
is a mess; with a bad case of assumed encapsulation.
Agreed, it is *really* ugly.
I've decided to alter the synclink drivers to work with and without the new assertion. That way, our customers can download updated drivers from our web site which will work with any 2.6 kernel.
Removing the assertion fixes things for the other drivers starting with kernel 2.6.5
--
Paul Fulghum
[email protected]