Skip to contentSkip to conversation

Sleep fix for iBook 800 sound

DISCUSSION Takashi Iwai 1 participant 1 message Apr 7, 2004 2 messages not in the archive

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive

Hi,

At Wed, 07 Apr 2004 16:35:11 +1000,

Quoted 7 lines · Benjamin Herrenschmidt
Quoted 4 lines · Ian McKellar

So,

I have an iBook 800Mhz and since I've moved to alsa and linux 2.6 I've had issues with sound oopsing in sleep, kind of like this:

Quoted 6 lines

Is sound working at all ? I suspect you didn't have the i2c-keywest module insmod'ed. There is indeed a problem in all our i2c based sound drivers where we don't always check that the i2c client was instanciated before doing some things...

Takashi, how is this patch ?

yes, the patch is fine, but i guess it won't fix Ian's mixer problem after resume. the real problem is that i2c.client is reset to NULL in sleep_notify callback.

i just took a quick look at dmasound code again, but the code path looks almost same, i.e.

	sleep_notify_callback(PBOOK_WAKE)
	-> leave_sleep callback
	-> resume mixer values

maybe dmasound resumes the mixer setting in somewhere else, too?

Takashi

-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click