Skip to contentSkip to conversation

patch-2.4.26.bz2, it wastes unnecessary 2 TIMES get_one_pte(mm, old_addr);

PATCH [email protected] 1 participant 1 message Apr 14, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi ;)

Quoted 1 line

From mm/mremap.c of patch-2.4.26.bz2: "It wastes unnecessary 2 TIMES

get_one_pte(mm, old_addr);"

mm/mremap.c +0 -0
diff -urN linux-2.4.25/mm/mremap.c linux-2.4.26/mm/mremap.c
@@ -77,12 +77,16 @@
 static int move_one_page(struct mm_struct *mm, unsigned long old_addr, unsigned

long new_addr)
{
int error = 0;
- pte_t * src;
+ pte_t * src, * dst;

spin_lock(&mm->page_table_lock);
src = get_one_pte(mm, old_addr);
- if (src)
- error = copy_one_pte(mm, src, alloc_one_pte(mm, new_addr));
+ if (src) {
+ dst = alloc_one_pte(mm, new_addr);
+ src = get_one_pte(mm, old_addr);
+ if (src)
+ error = copy_one_pte(mm, src, dst);
+ }
spin_unlock(&mm->page_table_lock);
return error;
}