Skip to contentSkip to conversation

please apply the old patch from Georg Acher in 2.4 tree

DISCUSSION Pete Zaitcev 1 participant 1 message May 17, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 1083011181.982.6.camel@muetdhiver

#1 lore raw
Quoted 13 lines · On Mon, 26 Apr 2004 22:26:21 +0200 Sebastien Chaumat <[email protected]> wrote:

I tried the patch from Georg Acher (posted 2001/08). It saved me from a
lot of troubles with a brand news USB2 hub that refuses to take an address with my nforce2 motherboard.

(quoted diff) +0 -5
@@ -2177,18 +2178,31 @@
 	dev->epmaxpacketin [0] = 8;
 	dev->epmaxpacketout[0] = 8;
 
-	err = usb_set_address(dev);
-	if (err < 0) {
-		err("USB device not accepting new address=%d (error=%d)",
-			dev->devnum, err);
-		clear_bit(dev->devnum, &dev->bus->devmap.devicemap);

Review line 2187

Quoted 10 lines
(quoted diff) +7 -3
-		dev->devnum = -1;
-		return 1;
-	}
+	for(m=0;m<2;m++) {
+		for(n=0;n<2;n++) {			
+			err = usb_set_address(dev);
+			if (err>=0)
+				break;
+			wait_ms(200);
+		}

I see this was admitted to 2.6, with nice symbolic constants, too. But before taking this, I would like someone to do this:
1. posess a device which flakes like the above
2. take the 2.6 version rediff and test it
3. explain to me why he or she cannot just run 2.6 and be content

If Sebastien is willing to clear these hurdles I erected (and mentions the vendor and device number of his hub), I'll think about it. But it would be best if someone else came forward.

-- Pete