befs i_flags thinko
PATCH 1/1 befs i_flags thinko
This was caught by Jörn Engel <[email protected]> some time ago. It is obviously correct. My public apologies to Jörn for delaying his patch.
linuxvfs.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
fs/befs/linuxvfs.c 2004-03-24 01:01:11.000000000 +0100 renamed from fs/befs/linuxvfs.c~ext23_inode_flags 2004-03-21 17:43:58.000000000 +0100 +1 -1
@@ -376,7 +376,7 @@ befs_ino->i_attribute = fsrun_to_cpu(sb, raw_inode->attributes); befs_ino->i_flags = fs32_to_cpu(sb, raw_inode->flags); - if (S_ISLNK(inode->i_mode) && !(inode->i_flags & BEFS_LONG_SYMLINK)) { + if (S_ISLNK(inode->i_mode) && !(befs_ino->i_flags & BEFS_LONG_SYMLINK)){ inode->i_size = 0; inode->i_blocks = befs_sb->block_size / VFS_BLOCK_SIZE; strncpy(befs_ino->i_data.symlink, raw_inode->data.symlink,
Quoted 4 lines · Will Dyson
This was caught by Jörn Engel <[email protected]> some time ago. It is obviously correct. My public apologies to Jörn for delaying his patch.
Hey, you just uncovered a race condition, see my mail from 1min ago. Not sure if I want to fix such a thing, though. ;)
Jörn
Signature · 3 lines
Beware of bugs in the above code; I have only proved it correct, but not tried it. -- Donald Knuth
Quoted 9 lines · Jörn Engel
Quoted 3 lines · Will Dyson
This was caught by Jörn Engel <[email protected]> some time ago. It is obviously correct. My public apologies to Jörn for delaying his patch.
Hey, you just uncovered a race condition, see my mail from 1min ago. Not sure if I want to fix such a thing, though. ;)
:)
Heh, your recent mail contains a description. Therefor, that is the one that should be used.
Signature · 2 lines
Will Dyson "Back off man, I'm a scientist!" -Dr. Peter Venkman