Skip to contentSkip to conversation

Trivial Comment Patch: 2.6.6-mm3

PATCH Danny Cox 2 participants 3 messages May 18, 2004 – May 19, 2004

lore
Share & tools
lore

Danny Cox

author
#0 lore raw

Andrew,

This fixes a comment in the stack overflow check that's wrong with 4K
stacks.

Sorry to attach it, but Evolution screws up the lines if it's inline.

Thanks!

Signature · 2 lines
Daniel S. Cox
Electronic Commerce Systems
irq.c renamed from irq.c.orig +1 -1
@@ -431,7 +431,7 @@
 	irq_enter();
 
 #ifdef CONFIG_DEBUG_STACKOVERFLOW
-	/* Debugging check for stack overflow: is there less than 1KB free? */
+	/* Debugging check for stack overflow: is there less than 512B free? */
 	{
 		long esp;
 
#1 lore raw

irq.c line 436

Quoted 8 lines · Danny Cox

This fixes a comment in the stack overflow check that's wrong with 4K stacks.

#ifdef CONFIG_DEBUG_STACKOVERFLOW

irq.c renamed from irq.c.orig +1 -1
-	/* Debugging check for stack overflow: is there less than 1KB free? */
+	/* Debugging check for stack overflow: is there less than 512B free? */
 	{
 		long esp;

akpm, how about just yank the line? the comment's sanity depends on a CONFIG option and also a value in another file from a far off land.

--cw

author
#2 lore raw

Chris,

Quoted 5 lines · Chris Wedgwood
Quoted 2 lines · Danny Cox

This fixes a comment in the stack overflow check that's wrong with 4K stacks.

Quoted 8 lines

irq.c line 436

Quoted 5 lines

#ifdef CONFIG_DEBUG_STACKOVERFLOW

irq.c renamed from irq.c.orig +1 -1
-	/* Debugging check for stack overflow: is there less than 1KB free? */
+	/* Debugging check for stack overflow: is there less than 512B free? */
 	{
 		long esp;

akpm, how about just yank the line? the comment's sanity depends on a CONFIG option and also a value in another file from a far off land.

IMHO, I'd say keep the line, but remove the offensive part (everything
past the ':', inclusive).

Signature · 2 lines
Daniel S. Cox
Electronic Commerce Systems