Skip to contentSkip to conversation

ppc64: Fix readq & writeq

PATCH New Benjamin Herrenschmidt 1 participant 1 message May 20, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc64: Fix readq & writeq

Hi Andrew !

This fixes busted asm constraints for readq & writeq implementation on ppc64 that resulted in garbage beeing generated for writeq (plus an obvious mistake in the prototype).

Please, apply
Ben.

===== include/asm-ppc64/io.h 1.17 vs edited =====

include/asm-ppc64/io.h +4 -4
@@ -326,7 +326,7 @@
 			     "rldicl %1,%1,32,0\n"
 			     "rlwimi %0,%1,8,8,31\n"
 			     "rlwimi %0,%1,24,16,23\n"
-			     : "=r" (ret), "=r" (tmp) : "b" (addr) , "m" (*addr));
+			     : "=r" (ret) , "=r" (tmp) : "b" (addr) , "m" (*addr));
 	return ret;
 }
 
@@ -339,7 +339,7 @@
 	return ret;
 }
 
-static inline void out_le64(volatile unsigned long *addr, int val)
+static inline void out_le64(volatile unsigned long *addr, unsigned long val)
 {
 	unsigned long tmp;
 
@@ -351,9 +351,9 @@
 			     "rldicl %1,%1,32,0\n"
 			     "rlwimi %0,%1,8,8,31\n"
 			     "rlwimi %0,%1,24,16,23\n"
-			     "std %0,0(%2)\n"
+			     "std %0,0(%3)\n"
 			     "sync"
-			     : "=r" (tmp) : "r" (val), "b" (addr) , "m" (*addr));
+			     : "=&r" (tmp) , "=&r" (val) : "1" (val) , "b" (addr) , "m" (*addr));
 }
 
 static inline void out_be64(volatile unsigned long *addr, int val)

** Sent via the linuxppc64-dev mail list. See http://lists.linuxppc.org/

Signature · 1 line
Benjamin Herrenschmidt <[email protected]>