Explicitly documenting patch submission
[this didn't have the right subject before, sorry]
Quoted 6 lines · Linus Torvalds
(Seriously, while nobody has actually complained about the suggested rules, I don't think anybody should feel compelled to do the sign-off before we've had more time to let people argue over it. People who feel comfortable with the suggestion are obviously encouraged to start asap, though).
I had been hoping someone had just forged your email address. :-/ You're not known for bureaucracy.
The wordy mix-case aspect is kind of annoying, and for all that we don't get to differentiate actions. I count:
1. came up with the design ideas
2. wrote the original patch
3. reviewed and passed on
4. modified
5. blindly passed on
Maybe "blindly passed on" needs nothing. So I'm thinking, if we must bother with all this...
designed:
authored:
reviewed:
modified:
Add "pirated:" if you like, so that searching for pirated code is easier than checking the evil bit.
Quoted 3 lines · Albert Cahalan
The wordy mix-case aspect is kind of annoying, and for all that we don't get to differentiate actions.
I actually really really don't want to differentiate actions. There's really no reason to try to separate things out, and quite often the actions are mixed anyway. Besides, if they all end up having the same technical meaning ("I have the right to pass on this patch") having separate flags is just sure to confuse the process.
So what I want is something _really_ simple. Something that is unambigious, and cannot be confused with something else. And in particular, I want that sign-off line to be "strange" enough that there is no possibility of ever writing that line by mistake - so that it is clear that the only reason anybody would write something like "Signed-off-by:" is because it meant _that_ particular thing.
In contrast, your suggestion of "modified:" is something that people might actually write when they write a changelog entry.
One reason for uniqueness is literally for automatic parsing - having scripts that pick up on this, and send ACK messages, or do statistics on who patches tend to go through etc etc.
Linus
Linus Torvalds <[email protected]> said:
[...]
Quoted 3 lines
One reason for uniqueness is literally for automatic parsing - having scripts that pick up on this, and send ACK messages, or do statistics on who patches tend to go through etc etc.
AFAIU, what you really want is to go back 20 years from now and say "See? Lines 257-300 of foo/bar.c were contributed originally by J. Random Hacker (here his signoff), and then modified by Jane Random and George Hacker, and Aunt Tillie's grandson looked it over and blessed it into the official kernel (signoffs here). If you got a problem with that, go talk to them." (that is what SCOundrels would need in place to be discouraged, I'm afraid...).
Problem with your proposal for this is that either you keep patches from the source intact (i.e., a bunch of one-liners each signed off separately, signed off each one by the maintainer, plus a patch by said maintainer to beat it all into useable shape) or shift the burden of being able to say later (even _much_ later) that the patch was the bundling and mangling of the individual patches.
I.e., this is an idea which was perhaps more appropiate in the olden days when there was no maintainer hierarchy in place yet...
Signature · 4 lines
Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 654431 Universidad Tecnica Federico Santa Maria +56 32 654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513