Skip to contentSkip to conversation

setup cpu_to_node for cpus not present

PATCH New Alex Williamson 1 participant 1 message Jun 4, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 setup cpu_to_node for cpus not present

In latest linux-2.5 bitkeeper, if you turn on CONFIG_HOTPLUG_CPU w/
an NR_CPUS greater than physically presents CPUs, you'll end up taking an MCA in __alloc_percpu(). kmem_cache_alloc_node() gets called with a node value of -1. It seems other architectures are defaulting the cpu_to_node map to zero for possible, but not present cpus. Here's a trivial patch that does the same for ia64. Thanks,

Alex

=== arch/ia64/kernel/smpboot.c 1.52 vs edited ==--- 1.52/arch/ia64/kernel/smpboot.c Fri May 21 15:54:17 2004
+++ edited/arch/ia64/kernel/smpboot.c Fri Jun 4 09:21:54 2004
@@ -525,7 +525,7 @@
#else
# error Fixme: Dunno how to build CPU-to-node map.
#endif
- cpu_to_node_map[cpu] = node;
+ cpu_to_node_map[cpu] = (node >= 0) ? node : 0;
if (node >= 0)
cpu_set(cpu, node_to_cpu_mask[node]);
}