Skip to contentSkip to conversation

Stop printk printing non-printable chars

PATCH Albert Cahalan 2 participants 2 messages Jun 19, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 6 lines · David Woodhouse

Please don't do that -- it makes printing UTF-8 impossible. While I'd not argue that now is the time to start outputting UTF-8 all over the place, I wouldn't accept that it's a good time to _prevent_ it either, as your patch would do.

If you want to post-process printk output, don't do it in the kernel.

It is dangerous to let the 0x9b character go out to a serial console. It means the same as ESC [ does when you have a normal 8-bit terminal.

Non-cannonical UTF-8 encoding for ESC and other troublesome characters may also cause problems.

#1 lore raw

On Sat, 2004-06-19 16:12:00 -0400, Albert Cahalan <[email protected]> wrote in message <1087675920.9831.941.camel@cube>:

Quoted 11 lines
Quoted 6 lines · David Woodhouse

Please don't do that -- it makes printing UTF-8 impossible. While I'd not argue that now is the time to start outputting UTF-8 all over the place, I wouldn't accept that it's a good time to _prevent_ it either, as your patch would do.

If you want to post-process printk output, don't do it in the kernel.

It is dangerous to let the 0x9b character go out to a serial console. It means the same as ESC [ does when you have a normal 8-bit terminal.

Get real: either you *want* to get those codes interpreted (think about full-blown ncurses apps being run over serial link), or you *don't* (think about simply recording serial console's output). You just have to choose the correct application for your task.

MfG, JBG

Signature · 4 lines
   Jan-Benedict Glaw       [email protected]    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));