Skip to contentSkip to conversation

emu10k1: difference between _fx8010_ and _efx_

DISCUSSION Lee Revell 2 participants 4 messages Jun 24, 2004 – Jun 25, 2004

lore
Share & tools
lore

Lee Revell

author
#0 lore raw

Hey,

I have been looking at the emu10k1 driver source and am confused about the use of _fx8010_ and _efx_ in variable names. The FX8010 is the DSP used for hardware "efx" in the EMU10K1. Can someone clarify the distinction?

It seems like these are almost used interchangable in some places, but I am sure there are important distinctions.

I have heard that these devices have something to do with AC3 passthrough.

Here is an example from emupcm.c:

int __devinit snd_emu10k1_pcm_efx(emu10k1_t * emu, int device, snd_pcm_t ** rpcm)

{
        snd_pcm_t *pcm;
        int err;

        if (rpcm)
                *rpcm = NULL;

        if ((err = snd_pcm_new(emu->card, "emu10k1 efx", device, 8, 1,
&pcm)) < 0)
                return err;

        pcm->private_data = emu;
        pcm->private_free = snd_emu10k1_pcm_efx_free;

        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK,

&snd_emu10k1_fx8010_playback_ops);
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE,
&snd_emu10k1_capture_efx_ops);

Lee

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com

#1 lore raw

At Thu, 24 Jun 2004 15:45:24 -0400,

Quoted 7 lines · Lee Revell

Hey,

I have been looking at the emu10k1 driver source and am confused about the use of _fx8010_ and _efx_ in variable names. The FX8010 is the DSP used for hardware "efx" in the EMU10K1. Can someone clarify the distinction?

No difference. They are named differently just because they _were_ different PCM streams before merged.

Takashi

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com

author
#2 lore raw
Quoted 5 lines · Takashi Iwai

At Thu, 24 Jun 2004 15:45:24 -0400,

Quoted 3 lines · Lee Revell

Hey,

Quoted 8 lines
Quoted 4 lines

I have been looking at the emu10k1 driver source and am confused about the use of _fx8010_ and _efx_ in variable names. The FX8010 is the DSP used for hardware "efx" in the EMU10K1. Can someone clarify the distinction?

No difference. They are named differently just because they _were_ different PCM streams before merged.

Ok. I have a patch to make the naming consistent (replacing efx with fx8010). This is pretty straightforward, there is only one conflict in emuproc.c which is easily resolved by renaming the function which reads the DSP microcode to snd_emu10k1_fx8010_read_code.

I tested this and everythng seems to work. However it looks like there is some other development going on in this driver so I have to regenerate it.

Lee

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com

author
#3 lore raw
In reply to Takashi Iwai
Quoted 5 lines · Takashi Iwai

At Thu, 24 Jun 2004 15:45:24 -0400,

Quoted 3 lines · Lee Revell

Hey,

Quoted 8 lines
Quoted 4 lines

I have been looking at the emu10k1 driver source and am confused about the use of _fx8010_ and _efx_ in variable names. The FX8010 is the DSP used for hardware "efx" in the EMU10K1. Can someone clarify the distinction?

No difference. They are named differently just because they _were_ different PCM streams before merged.

Ok. I have a patch to make the naming consistent (replacing efx with fx8010). This is pretty straightforward, there is only one conflict in emuproc.c which is easily resolved by renaming the function which reads the DSP microcode to snd_emu10k1_fx8010_read_code.

I tested this and everythng seems to work. However it looks like there is some other development going on in this driver so I have to regenerate it.

Lee

-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital self defense, top technical experts, no vendor pitches, unmatched networking opportunities. Visit www.blackhat.com