Skip to contentSkip to conversation

b44 and sundance watchdog changes.

PATCH/RFC Ian Kumlien 1 participant 1 message Jun 25, 2004 Network drivers

lore
Share & tools
lore
#0 lore raw

Hi,

I experimented some with the watchdog timers in these drivers because i had some problems with em.

sundance.c:
I first raised this to 8 (and had no problems with it) but since too many watchdog 'resets' breaks the hardware to the point where you have to actually shutdown the machine for a while, i thought, better safe than sorry.

b44.c:
My first try was to raise the timer to 10, but i actually got a failure, so i increased it again by a 5s increment.

This was tested while transfering ~20 gigs of data via nfs. The only problem that i experienced during this time is 2x:
b44: eth0: Link is down.
b44: eth0: Link is up at 100 Mbps, full duplex.
b44: eth0: Flow control is on for TX and on for RX.

There was no messages at all from the sundance driver, it worked perfectly.

Comments? suggestions?

PS. Sorry, couldn't find anyone listed in maintainers, so module authors was added to CC =P

CC me since i'm not subscribed.
DS.

Signature · 1 line
Ian Kumlien <pomac () vapor ! com> -- http://pomac.netswarm.net
drivers/net/b44.c renamed from drivers/net/b44.c.old +1 -1
@@ -43,7 +43,7 @@
 /* length of time before we decide the hardware is borked,
  * and dev->tx_timeout() should be called to fix the problem
  */
-#define B44_TX_TIMEOUT			(5 * HZ)
+#define B44_TX_TIMEOUT			(15 * HZ)
 
 /* hardware minimum and maximum for a single frame's data payload */
 #define B44_MIN_MTU			60
drivers/net/sundance.c renamed from drivers/net/sundance.c.old +1 -1
@@ -145,7 +145,7 @@
 
 /* Operational parameters that usually are not changed. */
 /* Time in jiffies before concluding the transmitter is hung. */
-#define TX_TIMEOUT  (4*HZ)
+#define TX_TIMEOUT  (10*HZ)
 #define PKT_BUF_SZ		1536	/* Size of each temporary Rx buffer.*/
 
 #ifndef __KERNEL__