Skip to contentSkip to conversation

Fix comment in include/linux/nodemask.h

PATCH In review Matthew Dobson 2 participants 2 messages Aug 26, 2004 Bitmap API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix comment in include/linux/nodemask.h

Andrew, here's a small comment fix for include/linux/nodemask.h. It's a comment that is only relevant to cpumasks and accidentally got copied over during my (failed) attempt to correctly post the nodemask code. The patch just updates the comment to make sense for nodemasks.

Thanks!

-Matt

include/linux/nodemask.h.fixed renamed from include/linux/nodemask.h +3 -6
@@ -69,12 +69,9 @@
  *
  * Subtlety:
  * 1) The 'type-checked' form of node_isset() causes gcc (3.3.2, anyway)
- *    to generate slightly worse code.  Note for example the additional
- *    40 lines of assembly code compiling the "for each possible node"
- *    loops buried in the disk_stat_read() macros calls when compiling
- *    drivers/block/genhd.c (arch i386, CONFIG_SMP=y).  So use a simple
- *    one-line #define for node_isset(), instead of wrapping an inline
- *    inside a macro, the way we do the other calls.
+ *    to generate slightly worse code.  So use a simple one-line #define 
+ *    for node_isset(), instead of wrapping an inline inside a macro, the 
+ *    way we do the other calls.
  */
 
 #include <linux/kernel.h>
#1 lore raw
Quoted 1 line · Matthew

a small comment fix for include/linux/nodemask.h.

Looks good.

Signature · 3 lines
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <[email protected]> 1.650.933.1373