Skip to contentSkip to conversation

__attribute__((always_inline)) fiasco

DISCUSSION Albert Cahalan 6 participants 12 messages Sep 23, 2004 – Sep 30, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines

I'm displeased with someone's workaround for decisions made by the (rather weak) inliner in gcc 3.[123]. In particular, that someone doesn't understand all of the implications of always_inline.

...

Quoted 8 lines

In the Alpha port I have a number of places in which I have functions that I would like inlined when they are called directly, but I also need to take their address so that they may be registered as part of a dispatch vector for the specific machine model.

This scheme fails because my functions got marked always_inline behind my back, which means they didn't get emitted in the right place.

If it hurts, don't do that. It looks like bloat anyway.

Are benchmarks significantly affected if you remove the inline? If so, simply have a second function:

extern void uninline_foo(void);
...
void uninline_foo(void)

{
        foo();
}
Quoted 8 lines

Rather than fight the unwinnable fight to remove this hack entirely, may I ask that at least one of the different names for inline, e.g. __inline__, be left un-touched so that it can be used by those that understand what the keyword is supposed to mean?

Of course, there does not exist a variant that isn't used by all sorts of random code, so presumably all existing occurences would have to get renamed to plan "inline" in order to keep people happy..

Hey, I argued for INLINE when the static/extern changes came along. That's the sanest, because one never knows what the next annoying compiler will demand. Then you can have one of:

#define INLINE
#define INLINE inline
#define INLINE static inline // an oxymoron
#define INLINE extern inline // an oxymoron
#define INLINE __force_inline
#define INLINE __attribute__((always_inline))
#define INLINE _Pragma("inline")
#define INLINE __inline_or_die_you_foul_compiler
#define INLINE _Please inline

#1 lore raw
Quoted 9 lines · Albert Cahalan

#define INLINE
#define INLINE inline
#define INLINE static inline // an oxymoron
#define INLINE extern inline // an oxymoron
#define INLINE __force_inline
#define INLINE __attribute__((always_inline))
#define INLINE _Pragma("inline")
#define INLINE __inline_or_die_you_foul_compiler
#define INLINE _Please inline

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is often very important. e.g.

static INLINE int lock_need_resched(spinlock_t *lock)

{
	...

-- wli

#2 lore raw
In reply to William Lee Irwin III
Quoted 11 lines · William Lee Irwin III
Quoted 9 lines · Albert Cahalan

#define INLINE
#define INLINE inline
#define INLINE static inline // an oxymoron
#define INLINE extern inline // an oxymoron
#define INLINE __force_inline
#define INLINE __attribute__((always_inline))
#define INLINE _Pragma("inline")
#define INLINE __inline_or_die_you_foul_compiler
#define INLINE _Please inline

Quoted 1 line

The // apart from being a C++ ism (screw C99; it's still non-idiomatic)

Once you get over the initial jolt of seeing new syntax, you'll find that C99 comments are clearly superior.

Even with block comments above functions, you'll typically save two lines of screen space. (and 7 bytes)

I think the only trouble is assembly code abusing
the C (note: "C", not "assembly") pre-processor.

Quoted 5 lines

will cause spurious ignorance of the remainder of the line, which is often very important. e.g.

static INLINE int lock_need_resched(spinlock_t *lock) {

Huh? Sure? It works for me:

albert 0 /tmp$ cat slash.c
#define MAIN main // test C99 comment
int MAIN (int argc, char *argv[]){
(void)argc;
(void)argv;
return 0;
}
albert 0 /tmp$ gcc -Wall -W -O2 slash.c
albert 0 /tmp$ ./a.out
albert 0 /tmp$ gcc -v
Reading specs from /usr/lib/gcc-lib/powerpc-linux/3.2.3/specs
Configured with: ../src/configure -v --enable-languages=c,c++,java,f77,objc,ada --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --with-gxx-include-dir=/usr/include/c++/3.2 --enable-shared --with-system-zlib --enable-nls --without-included-gettext --enable-__cxa_atexit --enable-clocale=gnu --enable-java-gc=boehm --enable-objc-gc powerpc-linux Thread model: posix
gcc version 3.2.3 20030415 (Debian prerelease)

#3 lore raw
In reply to William Lee Irwin III
Quoted 1 line · William Lee Irwin III
Quoted 1 line

#define INLINE static inline // an oxymoron

...

Quoted 5 lines

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is often very important. e.g.

static INLINE int lock_need_resched(spinlock_t *lock)

No it won't. Comments are removed in translation phase 3; macros are expanded in translation phase 4.

r~

#4 lore raw
In reply to William Lee Irwin III
Quoted 4 lines · William Lee Irwin III
Quoted 1 line

#define INLINE static inline // an oxymoron

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is

Usual Albert's taste level aside, you are wrong. Comments are replaced with whitespace on phase 3 (tokenizer) and preprocessor lives on phase 4. IOW, that // will never be seen by preprocessor.

#5 lore raw
Quoted 2 lines · William Lee Irwin III
Quoted 2 lines

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is

Quoted 3 lines · On Thu, Sep 23, 2004 at 06:21:04PM +0100…

Usual Albert's taste level aside, you are wrong. Comments are replaced with whitespace on phase 3 (tokenizer) and preprocessor lives on phase 4. IOW, that // will never be seen by preprocessor.

I'll be sure to put this on file with the rest of the numerous "while legal in C, never *EVER* do this" oddities.

-- wli

#6 lore raw
Quoted 11 lines · William Lee Irwin III
Quoted 2 lines · William Lee Irwin III
Quoted 2 lines

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is

Quoted 3 lines · On Thu, Sep 23, 2004 at 06:21:04PM +0100…

Usual Albert's taste level aside, you are wrong. Comments are replaced with whitespace on phase 3 (tokenizer) and preprocessor lives on phase 4. IOW, that // will never be seen by preprocessor.

I'll be sure to put this on file with the rest of the numerous "while legal in C, never *EVER* do this" oddities.

Huh? Comments (all sorts of comments) are dealt with before you get to preprocessing. Which *is* the right behaviour - anything else would be much, much messier. What's the problem with that?

#11 lore raw
In reply to Richard Henderson
Quoted 4 lines · Richard Henderson
Quoted 1 line · Albert Cahalan

Are benchmarks significantly affected if you remove the inline?

The routines in question expand to exactly one instruction.

Fine, but that's not what I asked.

I asked if it shows up on benchmarks. It doesn't, does it?

Supposing that it does, then you might use the alternate instruction replacement trick for this. That will beat function pointers for speed.

Also, a simple conditional branch might be better predicted than a function pointer anyway. At least it will be close.

So you have at least four reasonable choices:

a. don't inline at all
b. have an uninline_foo() version for each foo c. instruction replacement
d. simple conditional

The simple choices are better, unless you have benchmarks (whole system ones) that show otherwise.

#7 lore raw
In reply to William Lee Irwin III

Salut,

Quoted 11 lines · William Lee Irwin III
Quoted 2 lines · Albert Cahalan

#define INLINE static inline // an oxymoron
#define INLINE extern inline // an oxymoron

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is often very important. e.g.

static INLINE int lock_need_resched(spinlock_t *lock)

{
	...

Mmm, shouldn't the comments be filtered *before* the definition is set in place? Just wondering...

Tonnerre

#8 lore raw
Quoted 2 lines · Albert Cahalan
Quoted 2 lines
Quoted 2 lines

#define INLINE static inline // an oxymoron
#define INLINE extern inline // an oxymoron

Quoted 6 lines · William Lee Irwin III
Quoted 6 lines

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is often very important. e.g.
static INLINE int lock_need_resched(spinlock_t *lock)

{
	...
Quoted 2 lines · Tonnerre

Mmm, shouldn't the comments be filtered *before* the definition is set in place? Just wondering...

I've already heard more about this than I ever cared to. I'll continue to stick to saner subsets of C and refuse to use things such as how the preprocessor committing incest with the compiler proper (no, I don't need it explained to me, it's trivial) allows crappy code to be written. Don't lecture me; there's nothing to explain and I don't want to hear it.

-- wli

#9 lore raw
Quoted 22 lines · William Lee Irwin III
Quoted 2 lines · Albert Cahalan
Quoted 2 lines
Quoted 2 lines

#define INLINE static inline // an oxymoron
#define INLINE extern inline // an oxymoron

Quoted 6 lines · William Lee Irwin III
Quoted 6 lines

The // apart from being a C++ ism (screw C99; it's still non-idiomatic) will cause spurious ignorance of the remainder of the line, which is often very important. e.g.
static INLINE int lock_need_resched(spinlock_t *lock)

{
	...
Quoted 2 lines · Tonnerre

Mmm, shouldn't the comments be filtered *before* the definition is set in place? Just wondering...

Quoted 5 lines

I've already heard more about this than I ever cared to. I'll continue to stick to saner subsets of C and refuse to use things such as how the preprocessor committing incest with the compiler proper (no, I don't need it explained to me, it's trivial) allows crappy code to be written. Don't lecture me; there's nothing to explain and I don't want to hear it.

Don't hold back, tell us how you really feel ;-)

And I agree, those tricks shouldn't be used.

Signature · 3 lines
   -bill davidsen ([email protected])
"The secret to procrastination is to put things off until the
 last possible moment - but no longer"  -me