Skip to contentSkip to conversation

2.6.9-mm1 (about reiser4 patches)

DISCUSSION Christoph Hellwig 1 participant 1 message Oct 23, 2004 4 messages not in the archive VFS

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 2 lines · Christoph Hellwig

So what you want is actually to move the truncate_inode_pages out of generic_delete_inode and into ->delete_inode?

Looking at the code another strategt makes more sense:

- move the truncate_inode_pages at the beginning of clear_inode. All callers but one already do it just before that call, but the one that doesn't will require a full audit of all ->delete_inode instances
- make the first half of clear_inode into a helper (__clear_inode or whatever), and make ->clear_inode responsible for calling it as first thing for a normal fs or call it in clear_inode if ->clear_inode doesn't exist. that way we can also move the invalidate_inode_buffers out there easily later for filesystems that don't use buffer_heads at all.

p.s. please try to keep -fsdevel Cc'ed on the mail related to core changes