ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports
ia64 seems to rely on empty ports being registered. Without this, ia64 crashes on boot with
Removing wrong port: 0000000000000000 != a000000100781bd8
James
===== drivers/serial/8250.c 1.76 vs edited =====
drivers/serial/8250.c +0 -7
@@ -2001,13 +2001,6 @@for (i =0 ; i <UART_NR ; i++) {struct uart_8250_port *up = &serial8250_ports[i]; -/* Don't register "empty" ports, setting "ops" on them -* makes the console driver "setup" routine to succeed, -* which is wrong. --BenH. -*/ -if (!up->port.iobase) -continue ; - up->port.line = i; up->port.ops = &serial8250_pops; up->port.dev = dev;
Quoted 4 lines · James Bottomley
ia64 seems to rely on empty ports being registered. Without this, ia64 crashes on boot with
Removing wrong port: 0000000000000000 !=
a000000100781bd8
I send this patch to Linus already, though he may have missed it, I'll resend.
Ben.
Quoted 19 lines
James
=====
drivers/serial/8250.c1.76 vs edited =====drivers/serial/8250.c +0
-7@@ -2001,13 +2001,6 @@for (i =0 ; i <UART_NR ; i++) {struct uart_8250_port *up = &serial8250_ports[i]; -/* Don't register "empty" ports, setting "ops" on them -* makes the console driver "setup" routine to succeed, -* which is wrong. --BenH. -*/ -if (!up->port.iobase) -continue ; - up->port.line = i; up->port.ops = &serial8250_pops; up->port.dev = dev;
Signature · 1 line
Benjamin Herrenschmidt <[email protected]>