Skip to contentSkip to conversation

Fixing MTRR smp breakage and suspending sysdevs.

DISCUSSION Nigel Cunningham 1 participant 1 message Oct 26, 2004

lore
Share & tools
lore
#0 lore raw

Hi!

I've just had a go at fixing the issue with my implementation not suspending the sysdevs (I believe swsusp does the same). In the process, I reworked the MTRR support so it's not treated as a sysdev. Instead, when we're saving cpu state, the mtrr_save function function is called. When we go to restore CPU state, each CPU calls a function that resets it's MTRRs and the 'main' cpu then frees the saved data. This is working well here (did a dozen plus suspends on the trot), but I want to check that it sounds like the right solution to you.

Perhaps this method should be made more generic? (Are there likely to be other per-cpu state savers needed?)

One thing I have noticed is that by adding the sysdev suspend/resume calls, I've gained a few seconds delay. I'll see if I can track down the cause.

Regards,

Nigel

Signature · 7 lines
Nigel Cunningham
Pastoral Worker
Christian Reformed Church of Tuggeranong
PO Box 1004, Tuggeranong, ACT 2901

Everyone lives by faith. Some people just don't believe it.
Want proof? Try to prove that the theory of evolution is true.