Skip to contentSkip to conversation

scsi/zalon: Added KERN macro to printk()

PATCH In review Andrew McGregor 2 participants 3 messages Nov 16, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi/zalon: Added KERN macro to printk()

Hi,

I have added a KERN macro to a printk() function as requested in the Kernel Janitor's TODO list.

--

--- drivers/scsi/zalon.c Mon Nov 15 23:38:14 2004
+++ /root/linux/janitor-linux-2.6.9/drivers/scsi/zalon.c Mon Nov 15
23:38:01 2004
@@ -109,7 +109,7 @@ zalon_probe(struct parisc_device *dev)

        */
        irq = gsc_alloc_irq(&gsc_irq);

- printk("%s: Zalon vers field is 0x%x, IRQ %d\n", __FUNCTION__,
+ printk(KERN_INFO "%s: Zalon vers field is 0x%x, IRQ %d\n", __FUNCTION__,

                zalon_vers, irq);

        __raw_writel(gsc_irq.txn_addr | gsc_irq.txn_data, dev->hpa +

IO_MODULE_EIM);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

root/linux/janitor-linux-2.6.9/drivers/scsi/zalon.c Mon Nov 15

Quoted 11 lines · Andrew McGregor

Hi,

I have added a KERN macro to a printk() function as requested in the Kernel Janitor's TODO list.

--

root/linux/janitor-linux-2.6.9/drivers/scsi/zalon.c Mon Nov 15 renamed from scsi/zalon.c Mon Nov 15 23:38:14 2004 +0 -0

please follow SubmittingPatches,
patches should apply with -p1.

Quoted 10 lines

23:38:01 2004

root/linux/janitor-linux-2.6.9/drivers/scsi/zalon.c Mon Nov 15 renamed from scsi/zalon.c Mon Nov 15 23:38:14 2004 +1 -1
@@ -109,7 +109,7 @@ zalon_probe(struct parisc_device *dev)
        */
        irq = gsc_alloc_irq(&gsc_irq);
 
-       printk("%s: Zalon vers field is 0x%x, IRQ %d\n", __FUNCTION__,
+       printk(KERN_INFO "%s: Zalon vers field is 0x%x, IRQ %d\n", __FUNCTION__,
                zalon_vers, irq);
 
        __raw_writel(gsc_irq.txn_addr | gsc_irq.txn_data, dev->hpa +
Quoted 2 lines

IO_MODULE_EIM);

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Andrew McGregor

Quoting maximilian attems <[email protected]>:

Quoted 2 lines

please follow SubmittingPatches,
patches should apply with -p1.

Hi,

Thank you for your reply. Please find below my second attempt at a kernel patch.

I have added a KERN macro to a printk() function as requested in the Kernel Janitor's TODO list.

---

drivers/scsi/zalon.c Tue Nov 16 14:29:44 2004 renamed from drivers/scsi/zalon.c.orig Tue Nov 16 14:29:22 2004 +1 -1
@@ -109,7 +109,7 @@ zalon_probe(struct parisc_device *dev)
        */
        irq = gsc_alloc_irq(&gsc_irq);
 
-       printk("%s: Zalon vers field is 0x%x, IRQ %d\n", __FUNCTION__,
+       printk(KERN_INFO "%s: Zalon vers field is 0x%x, IRQ %d\n", __FUNCTION__,
                zalon_vers, irq);
 
        __raw_writel(gsc_irq.txn_addr | gsc_irq.txn_data, dev->hpa +

IO_MODULE_EIM);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors