Skip to contentSkip to conversation

cciss: Off-by-one error causing oops in CCISS_GETLUNIFO ioctl

PATCH New Andrew Patterson 1 participant 1 message Nov 24, 2004 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cciss: Off-by-one error causing oops in CCISS_GETLUNIFO ioctl

This patch fixes an an "off-by-one" error found in the CCISS_GETLUNIFO ioctl in the cciss driver. It is cycling through the part table of the gendisk structure which is a zero-based array, not a one-based array. This often causes an oops when referencing the out-of-bounds element.

Signed-off by: Andrew Patterson <[email protected]>
---

drivers/block/cciss.c renamed from drivers/block/cciss.c.orig +1 -1
@@ -799,7 +799,7 @@
  		luninfo.num_opens = drv->usage_count;
  		luninfo.num_parts = 0;
  		/* count partitions 1 to 15 with sizes > 0 */
- 		for(i=1; i <MAX_PART; i++) {
+ 		for(i=0; i <MAX_PART-1; i++) {
 			if (!disk->part[i])
 				continue;
 			if (disk->part[i]->nr_sects != 0)