Skip to contentSkip to conversation

Block layer question - indicating EOF on block devices

DISCUSSION Alan Cox 3 participants 6 messages Nov 30, 2004 – Dec 2, 2004

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

How is a block device meant to indicate to the block layer that the read issued is beyond EOF. For the case where the true EOF is known the capacity information is propogated into the inode and that is used. For the case where a read exceeds the known EOF the block layer sets BIO_EOF which appears nowhere else I can find.

I'm trying to sort out the case where the block device has only an approximate length known in advance. At the low level I've got sense data so I know precisely when I hit the real EOF on read. I can pull that out, I can partially complete the request neatly up to the EOF but I can't find any code anywhere dealing with passing back an EOF.

Nor it turns out is it handleable in user space because a read to the true EOF causes readahead into the fuzzy zone between the actual EOF and the end of media.

Currently I see the error, pull the sense data, extract the block number and complete the request to the point it succeeded then fail the rest, but this doesn't end the I/O if someone is using something like cp, and it also fills the log with "I/O error on" spew from the block layer innards even if REQ_QUIET is magically set.

#1 lore raw
Quoted 7 lines · Alan Cox

How is a block device meant to indicate to the block layer that the read issued is beyond EOF. For the case where the true EOF is known the capacity information is propogated into the inode and that is used. For the case where a read exceeds the known EOF the block layer sets BIO_EOF which appears nowhere else I can find.

Quoted 5 lines

I'm trying to sort out the case where the block device has only an approximate length known in advance. At the low level I've got sense data so I know precisely when I hit the real EOF on read. I can pull that out, I can partially complete the request neatly up to the EOF but I can't find any code anywhere dealing with passing back an EOF.

If the driver simply returns an I/O error, userspace should see a short read and be happy?

Quoted 3 lines

Nor it turns out is it handleable in user space because a read to the true EOF causes readahead into the fuzzy zone between the actual EOF and the end of media.

Yup. You can turn the readahead off with posix_fadvise(POSIX_FADV_RANDOM), or just read the disk with direct-io. The latter has the advantage that you can freely pluck out single 512-byte sectors without pagecache causing any additional reads.

Quoted 3 lines

Currently I see the error, pull the sense data, extract the block number and complete the request to the point it succeeded then fail the rest, but this doesn't end the I/O if someone is using something like cp,

hm. Either cp is being silly or we're not propagating the error back correctly. `cp' should see the short read and just handle it.

Quoted 3 lines

and
it also fills the log with "I/O error on" spew from the block layer innards even if REQ_QUIET is magically set.

We'd need to propagate that quietness back up to the buffer_head layer, at least.

author
#2 lore raw
Quoted 3 lines · Andrew Morton

Alan Cox <[email protected]> wrote:
If the driver simply returns an I/O error, userspace should see a short read and be happy?

And the logs fill with I/O error messages.

Quoted 5 lines
Quoted 3 lines

Nor it turns out is it handleable in user space because a read to the true EOF causes readahead into the fuzzy zone between the actual EOF and the end of media.

Yup. You can turn the readahead off with posix_fadvise(POSIX_FADV_RANDOM),

Can't do this during a mount.

Quoted 6 lines
Quoted 3 lines

Currently I see the error, pull the sense data, extract the block number and complete the request to the point it succeeded then fail the rest, but this doesn't end the I/O if someone is using something like cp,

hm. Either cp is being silly or we're not propagating the error back correctly. `cp' should see the short read and just handle it.

I'll strace that and see what else I can find. Now I'm partially completing requests when this problem occurs it does seem somewhat happier. The original code when I took it to bits was just blindingly failing the lot.

Quoted 6 lines
Quoted 3 lines

and
it also fills the log with "I/O error on" spew from the block layer innards even if REQ_QUIET is magically set.

We'd need to propagate that quietness back up to the buffer_head layer, at least.

Thats what I was assuming looking at the code. Really the block layer is broken here. It should not be whining about I/O errors on readahead blocks just letting them go. It has no idea if the readahead is a badblock a media feature or whatever. (or as James added on irc scsi reservations).

Alan

#3 lore raw
Quoted 6 lines · Alan Cox
Quoted 3 lines · Andrew Morton

Alan Cox <[email protected]> wrote:
If the driver simply returns an I/O error, userspace should see a short read and be happy?

And the logs fill with I/O error messages.

read-ahead should definitely be marked quiet, agree.

Quoted 4 lines
Quoted 4 lines
Quoted 3 lines

and
it also fills the log with "I/O error on" spew from the block layer innards even if REQ_QUIET is magically set.

Quoted 8 lines
Quoted 2 lines

We'd need to propagate that quietness back up to the buffer_head layer, at least.

Thats what I was assuming looking at the code. Really the block layer is broken here. It should not be whining about I/O errors on readahead blocks just letting them go. It has no idea if the readahead is a badblock a media feature or whatever. (or as James added on irc scsi reservations).

The upper buffer layer could do something intelligent if EOF is set on the bio, it really should. The problem is that there's no -EXXX to flag EOF from the driver, it would be nicest if one could just do:

	end_that_request_chunk(req, 1, good_bytes);
	end_that_request_chunk(req, -EOF, residual);

and be done with it.

Signature · 1 line
Jens Axboe
author
#4 lore raw
Quoted 7 lines · Jens Axboe

The upper buffer layer could do something intelligent if EOF is set on the bio, it really should. The problem is that there's no -EXXX to flag EOF from the driver, it would be nicest if one could just do:

	end_that_request_chunk(req, 1, good_bytes);
	end_that_request_chunk(req, -EOF, residual);

We have a set of internal error codes around -512 for things like "please use
the default ioctl behaviour". The error codes don't seem to get propogated up through the page cache however when I tried using this (I just "borrowed"
-ENOMEDIUM for testing) with the idea of catching it at the top.

#5 lore raw
Quoted 9 lines · Alan Cox
Quoted 7 lines · Jens Axboe

The upper buffer layer could do something intelligent if EOF is set on the bio, it really should. The problem is that there's no -EXXX to flag EOF from the driver, it would be nicest if one could just do:

	end_that_request_chunk(req, 1, good_bytes);
	end_that_request_chunk(req, -EOF, residual);
Quoted 6 lines

We have a set of internal error codes around -512 for things like "please use
the default ioctl behaviour". The error codes don't seem to get propogated up through the page cache however when I tried using this (I just "borrowed"
-ENOMEDIUM for testing) with the idea of catching it at the top.

It gets passed to the bio->bi_end_io end io handler, but most likely that doesn't do anything with it (most just treat it as a bool). That's where the improvement room is, basically :)

Signature · 1 line
Jens Axboe