Skip to contentSkip to conversation

ip_conntrack_irc:parse_dcc should be static

PATCH New Rusty Russell 1 participant 1 message Dec 15, 2004

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 1/1 ip_conntrack_irc:parse_dcc should be static

Name: ip_conntrack_irc:parse_dcc should be static
Status: Trivial

Signed-off-by Rusty Russell <[email protected]>

Found by nfsim (-Wmissing-prototypes is your friend).

net/ipv4/netfilter/ip_conntrack_irc.c +2 -2
Index: linux-2.6.10-rc3-bk6-Netfilter/net/ipv4/netfilter/ip_conntrack_irc.c
===================================================================
@@ -65,8 +65,8 @@
 #define DEBUGP(format, args...)
 #endif
 
-int parse_dcc(char *data, char *data_end, u_int32_t * ip, u_int16_t * port,
-	      char **ad_beg_p, char **ad_end_p)
+static int parse_dcc(char *data, char *data_end, u_int32_t *ip,
+		     u_int16_t *port, char **ad_beg_p, char **ad_end_p)
 /* tries to get the ip_addr and port out of a dcc command
    return value: -1 on failure, 0 on success 
 	data		pointer to first byte of DCC command data
Signature · 1 line
A bad analogy is like a leaky screwdriver -- Richard Braakman