Fix return value when proc file creation fails in ip_conntrack
PATCH 1/1 Fix return value when proc file creation fails in ip_conntrack
Name: Fix return value when proc file creation fails in ip_conntrack
Status: Tested
We notiecd proc_net_fops_create() failing, and cleaned up, but returned 0 anyway.
Found by the --failtest flag to nfsim-testsuite. --failtest rocks my world.
Index:linux-2.6.10-rc3-bk6-Netfilter/net/ipv4/netfilter/ip_conntrack_standalone.c
===================================================================
---linux-2.6.10-rc3-bk6-Netfilter.orig/net/ipv4/netfilter/ip_conntrack_standalone.c 2004-12-15 14:37:23.464334568 +1100
+++linux-2.6.10-rc3-bk6-Netfilter/net/ipv4/netfilter/ip_conntrack_standalone.c 2004-12-15 14:38:12.893820144 +1100
@@ -741,6 +741,7 @@
goto cleanup_nothing;
#ifdef CONFIG_PROC_FS
+ ret = -ENOMEM;
proc = proc_net_fops_create("ip_conntrack", 0440, &ct_file_ops); if (!proc) goto cleanup_init;
Signature · 1 line
A bad analogy is like a leaky screwdriver -- Richard Braakman