Skip to contentSkip to conversation

AC97 plugin suspend/resume

PATCH Superseded Liam Girdwood 2 participants 3 messages Jan 4, 2005 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 AC97 plugin suspend/resume

This patch sets suspend and resume to NULL in the ad1980 plugin.

Liam

sound/oss/ac97_plugin_ad1980.c +2 -0
@@ -89,6 +89,8 @@
 	.name		= "AD1980 example",
 	.probe		= ad1980_probe,
 	.remove		= __devexit_p(ad1980_remove),
+	.suspend	= NULL,
+	.resume		= NULL,
 };
 
 /**
#1 lore raw
Quoted 12 lines · Liam Girdwood

This patch sets suspend and resume to NULL in the ad1980 plugin.

Liam

------------------------------------------------------------------------

sound/oss/ac97_plugin_ad1980.c line 96

Quoted 8 lines
sound/oss/ac97_plugin_ad1980.c +2 -0
@@ -89,6 +89,8 @@
 	.name		= "AD1980 example",
 	.probe		= ad1980_probe,
 	.remove		= __devexit_p(ad1980_remove),
+	.suspend	= NULL,
+	.resume		= NULL,
 };
 
 /**

There is really no reason to add these fields if they are NULL. Zero (or NULL for pointers) is the default for all unspecified fields, and it is kernel convention to use this feature to reduce clutter.

--
Brian Gerst

#2 lore raw
Quoted 4 lines · Brian Gerst

There is really no reason to add these fields if they are NULL. Zero (or NULL for pointers) is the default for all unspecified fields, and it is kernel convention to use this feature to reduce clutter.

Ok, patch 2/2 can be safely ignored. It was added for clarity.

Liam