Panasonic ACPI driver
PATCH 1/1 Panasonic ACPI driver
Hi,
this is another ACPI driver for several Panasonic notebooks. The driver provides support for hotkeys and enables access to other hardware like reading/setting the LCD brightness.
Like the Sony ACPI driver--recently sent by Stelian Pop--it would be good to to see this one to be integrated into the -mm tree, too.
The attached patch is against 2.6.11-rc3.
Thanks,
-- Timo
..............................................................
Timo Hönig <thoenig at suse dot de> ..................................................:: gpg ::...
Fingerprint: 0998 0ACA A1D2 2612 4D96 DD8B E03F 084B B305 4066
drivers/acpi/Kconfig +16 -0
@@ -242,6 +242,22 @@ If you have a legacy free Toshiba laptop (such as the Libretto L1 series), say Y. +config ACPI_PCC + tristate "Panasonic Laptop Extras" + depends on X86 + depends on ACPI_INTERPRETER + default m + ---help--- + This driver implements hotkey functionality and access to + various hardware (e.g. LCD brightness) for the + Panasonic R1 (N variant), R2, R3, T2, W2, and Y2 laptops. + + Further details and user space tools are available at + <http://www.da-cha.org/letsnote/>. + + If you have one of the above listed Panasonic laptops + say Y or M here. + config ACPI_CUSTOM_DSDT bool "Include Custom DSDT" depends on ACPI_INTERPRETER && !STANDALONE
drivers/acpi/Makefile +1 -0
@@ -54,4 +54,5 @@ obj-$(CONFIG_ACPI_ASUS) += asus_acpi.o obj-$(CONFIG_ACPI_IBM) += ibm_acpi.o obj-$(CONFIG_ACPI_TOSHIBA) += toshiba_acpi.o +obj-$(CONFIG_ACPI_PCC) += pcc_acpi.o obj-$(CONFIG_ACPI_BUS) += scan.o motherboard.o
drivers/acpi/pcc_acpi.c +937 -0
937 lines not on this page · raw message
We should not include this driver in the kernel.
Rather than adding additional platform-specific drivers, we should be migrating away from those that we already have to simpler generic drivers for video and hot-keys -- where the platform-dependent (naming) is done in user-space where it is more extensible and supportable.
We've already got video.c, and I believe that we should start to migrate to something like Luming's hot-key driver (see earlier acpi-devel posts) in 2.6.12.
If a platform has some unique feature that no other platform in the world has, then that justifies a platform specific driver for that unique feature. But for the common features, the community will be better served by the simpler generic kernel drivers that work on more systems.
thanks,
-Len
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click