Skip to contentSkip to conversation

ppc32: kernel mapping breakage

PATCH New Benjamin Herrenschmidt 1 participant 1 message Feb 23, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc32: kernel mapping breakage

Hi !

Christoph Lameter's patch that change page allocators to use GFP_ZERO broke ppc32 in a subtle way. Our allocator is designed to work before mem_init_done, in which cases it uses a ppc specific early_get_page() which doesn't return zeroed pages. However, he removed the call to clear_page() unconditionally, thus causing the kernel initial page tables to have random data in them.

They are initialized with set_pte, which means it's _mostly_ harmless, except that set_pte on ppc32 preserves the _PAGE_HASHPTE bit, thus we end up with random bits there, which can cause issues with further manipulation of the kernel page tables and will slow down all hash faults to them causing unnecessary searches.

Please apply in 2.6.11 if still possible ...

arch/ppc/mm/pgtable.c +4 -1
Index: linux-work/arch/ppc/mm/pgtable.c
===================================================================
@@ -107,8 +107,11 @@
 			ptepage->mapping = (void *) mm;
 			ptepage->index = address & PMD_MASK;
 		}
-	} else
+	} else {
 		pte = (pte_t *)early_get_page();
+		if (pte)
+			clear_page(pte);
+	}
 	return pte;
 }