Skip to contentSkip to conversation

memset usage fix

PATCH New Vinay K Nallamothu 1 participant 1 message Mar 31, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 memset usage fix

Hi Marc,

Using Dave Jones memset script to detect swapped arguments, I found two such instances. Patch attached.

Thanks
Vinay

 nubus/nubus.c |    2 +-
 usb/dabusb.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

=========================================================================

drivers/usb/dabusb.c +1 -1
diff -urN linux-2.2.26/drivers/usb/dabusb.c linux-2.2.26-m/drivers/usb/dabusb.c
@@ -224,7 +224,7 @@
 			err("kmalloc(sizeof(buff_t))==NULL");
 			goto err;
 		}
-		memset (b, sizeof (buff_t), 0);
+		memset (b, 0, sizeof (buff_t));
 		b->s = s;
 		b->purb = usb_alloc_urb(packets);
 		if (!b->purb) {
drivers/nubus/nubus.c +1 -1
diff -urN linux-2.2.26/drivers/nubus/nubus.c linux-2.2.26-m/drivers/nubus/nubus.c
@@ -563,7 +563,7 @@
 		/* Now clobber the whole thing */
 		if (size > sizeof(mode) - 1)
 			size = sizeof(mode) - 1;
-		memset(&mode, sizeof(mode), 0);
+		memset(&mode, 0, sizeof(mode));
 		nubus_get_rsrc_mem(&mode, &ent, size);
 		printk (KERN_INFO "      %02X: (%02X) %s\n", ent.type,
 			mode.id, mode.name);

=========================================================================

Signature · 4 lines
Views expressed in this mail are those of the individual sender and 
do not bind Gsec1 Limited. or its subsidiary, unless the sender has done
so expressly with due authority of Gsec1.
_________________________________________________________________________