Skip to contentSkip to conversation

procfs privacy: /proc/bus/pci

PATCH In review Lorenzo Hernández García-Hierro 2 participants 2 messages Apr 18, 2005 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/7 procfs privacy: /proc/bus/pci

This patch changes the permissions of the /proc/bus/pci directory entry, so, non-root users are restricted of accessing it's content.

It's also available at:
http://pearls.tuxedo-es.org/patches/security/proc-privacy-1_drivers_pci_proc.c.patch

Signature · 2 lines
Lorenzo Hernández García-Hierro <[email protected]> 
[1024D/6F2B2DEC] & [2048g/9AE91A22][http://tuxedo-es.org]
drivers/pci/proc.c renamed from drivers/pci/proc.c~proc-privacy-1 +2 -2
diff -puN drivers/pci/proc.c~proc-privacy-1 drivers/pci/proc.c
@@ -565,7 +565,7 @@ static struct file_operations proc_pci_o
 
 static void legacy_proc_init(void)
 {
-	struct proc_dir_entry * entry = create_proc_entry("pci", 0, NULL);
+	struct proc_dir_entry * entry = create_proc_entry("pci", S_IRUSR, NULL);
 	if (entry)
 		entry->proc_fops = &proc_pci_operations;
 }
@@ -594,7 +594,7 @@ static int __init pci_proc_init(void)
 {
 	struct proc_dir_entry *entry;
 	struct pci_dev *dev = NULL;
-	proc_bus_pci_dir = proc_mkdir("pci", proc_bus);
+	proc_bus_pci_dir = proc_mkdir_mode("pci", S_IRUSR | S_IXUSR, proc_bus);
 	entry = create_proc_entry("devices", 0, proc_bus_pci_dir);
 	if (entry)
 		entry->proc_fops = &proc_bus_pci_dev_operations;
#1 lore raw
Quoted 14 lines · Lorenzo Hernández García-Hierro

This patch changes the permissions of the /proc/bus/pci directory entry, so, non-root users are restricted of accessing it's content. It's also available at:
http://pearls.tuxedo-es.org/patches/security/proc-privacy-1_drivers_pci_
proc.c.patch

Signature · 8 lines
Lorenzo Hernández García-Hierro <[email protected]> 
[1024D/6F2B2DEC] & [2048g/9AE91A22][http://tuxedo-es.org]


begin 600 proc-privacy-1_drivers_pci_proc.c.patch
M9&EF9B`M<'5.(&1R:79E<G,O<&-I+W!R;V,N8WYP<F]C+7!R:79A8WDM,2!D
M<FEV97)S+W!C:2]P<F]C+F,-"BTM+2!L:6YU>"TR+C8N,3$O9')I=F5R<R]P
M8VDO<')O8RYC?G!R;V,M<')I=F%C>2TQ"3(P,#4M,#0M,3<@,3<Z-3`Z-#DN

[snip]

Please send patches inline in emails. Not uuencoded, not as attachments, just plain inline text.

Signature · 1 line
Jesper Juhl