Skip to contentSkip to conversation

fallocate can't change the cifs disk space usage

DISCUSSION Xiaoli Feng 2 participants 7 messages Aug 3, 2020 – Aug 6, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hello all,

Recently when I'm investigating the xfstests generic/213 generic/228 failures for cifs. Found that fallocate can't change the cifs disk space usage. Comparing xfs fileystem, fallocate can update space usage.

My tests is in 5.8.0-rc7+. I also file a bug for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=208775

# cat /etc/samba/smb.conf
[cifs]
path=/mnt/cifs
writeable=yes
# mount //localhost/cifs cifs -o user=root,password=redhat,cache=none,actimeo=0
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
#  fallocate -o 0 -l 2g /root/cifs/file1
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
]# ls -l cifs
total 1
-rwxr-xr-x. 1 root root 2147483648 Aug  2 21:57 file1

Thanks.

Signature · 2 lines
Best regards!
XiaoLi Feng 冯小丽
#2 lore raw

Any luck trying the same thing to Windows and/or Azure to see if this is possible Samba bug - sounds like possible Samba server bug but need more information.

Are you using one of the Samba plug in VFS modules on the server (like vfs_btrfs)?

What does the filesystem show (before and after) on the server side (local file system not just the remote view that Samba is returning for statfs) when you try the df -h?

Quoted 32 lines · Xiaoli Feng

Hello all,

Recently when I'm investigating the xfstests generic/213 generic/228 failures for cifs. Found that fallocate can't change the cifs disk space usage. Comparing xfs fileystem, fallocate can update space usage.

My tests is in 5.8.0-rc7+. I also file a bug for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=208775

# cat /etc/samba/smb.conf
[cifs]
path=/mnt/cifs
writeable=yes
# mount //localhost/cifs cifs -o user=root,password=redhat,cache=none,actimeo=0
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
#  fallocate -o 0 -l 2g /root/cifs/file1
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
]# ls -l cifs
total 1
-rwxr-xr-x. 1 root root 2147483648 Aug  2 21:57 file1

Thanks.

--
Best regards!
XiaoLi Feng 冯小丽

Signature · 3 lines
Thanks,

Steve
#3 lore raw

Hell Steve,

----- Original Message -----

Quoted 9 lines

From: "Steve French" <[email protected]>
To: "Xiaoli Feng" <[email protected]>
Cc: "CIFS" <[email protected]>, "samba-technical" <[email protected]>
Sent: Monday, August 3, 2020 12:42:32 PM
Subject: Re: fallocate can't change the cifs disk space usage

Any luck trying the same thing to Windows and/or Azure to see if this is possible Samba bug - sounds like possible Samba server bug but need more information.

Thanks for quick response. When trying the same thing to windows. This issue is gone. fallocate can update the space usage.

Quoted 3 lines

Are you using one of the Samba plug in VFS modules on the server (like vfs_btrfs)?

I'm not using any samba plug in vfs.

Quoted 4 lines

What does the filesystem show (before and after) on the server side (local file system not just the remote view that Samba is returning for statfs) when you try the df -h?

on the server side, the space usage reported by df also keep the same before and after fallocate.

Quoted 45 lines · Xiaoli Feng
Quoted 29 lines

Hello all,

Recently when I'm investigating the xfstests generic/213 generic/228 failures for cifs.
Found that fallocate can't change the cifs disk space usage. Comparing xfs fileystem,
fallocate can update space usage.

My tests is in 5.8.0-rc7+. I also file a bug for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=208775

# cat /etc/samba/smb.conf
[cifs]
path=/mnt/cifs
writeable=yes
# mount //localhost/cifs cifs -o
user=root,password=redhat,cache=none,actimeo=0
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
#  fallocate -o 0 -l 2g /root/cifs/file1
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
]# ls -l cifs
total 1
-rwxr-xr-x. 1 root root 2147483648 Aug  2 21:57 file1
Quoted 6 lines

Thanks.

--
Best regards!
XiaoLi Feng 冯小丽

--
Thanks,

Steve

#4 lore raw
In reply to Xiaoli Feng

So locally on xfs this works, but Samba when receiving the request remotely apparently isn't doing the fallocate. Would be curious if this works with vfs_btrfs and btrfs filesystem on the share - or a Samba server bug.

Quoted 32 lines · Xiaoli Feng

Hello all,

Recently when I'm investigating the xfstests generic/213 generic/228 failures for cifs. Found that fallocate can't change the cifs disk space usage. Comparing xfs fileystem, fallocate can update space usage.

My tests is in 5.8.0-rc7+. I also file a bug for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=208775

# cat /etc/samba/smb.conf
[cifs]
path=/mnt/cifs
writeable=yes
# mount //localhost/cifs cifs -o user=root,password=redhat,cache=none,actimeo=0
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
#  fallocate -o 0 -l 2g /root/cifs/file1
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
]# ls -l cifs
total 1
-rwxr-xr-x. 1 root root 2147483648 Aug  2 21:57 file1

Thanks.

--
Best regards!
XiaoLi Feng 冯小丽

Signature · 3 lines
Thanks,

Steve
#5 lore raw

One of the things that Samba server appears to be doing wrong is that Samba is creating the file as a sparse file and returning that it is not a sparse file - this obviously creates a problem because an fallocate on a non-sparse file can be a no op ... but the server didn't tell us it was a sparse file ...

Quoted 45 lines · Steve French

So locally on xfs this works, but Samba when receiving the request remotely apparently isn't doing the fallocate. Would be curious if this works with vfs_btrfs and btrfs filesystem on the share - or a Samba server bug.

Quoted 26 lines · Xiaoli Feng

Hello all,

Recently when I'm investigating the xfstests generic/213 generic/228 failures for cifs. Found that fallocate can't change the cifs disk space usage. Comparing xfs fileystem, fallocate can update space usage.

My tests is in 5.8.0-rc7+. I also file a bug for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=208775

# cat /etc/samba/smb.conf
[cifs]
path=/mnt/cifs
writeable=yes
# mount //localhost/cifs cifs -o user=root,password=redhat,cache=none,actimeo=0
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
#  fallocate -o 0 -l 2g /root/cifs/file1
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
]# ls -l cifs
total 1
-rwxr-xr-x. 1 root root 2147483648 Aug  2 21:57 file1
Quoted 6 lines

Thanks.

--
Best regards!
XiaoLi Feng 冯小丽

--
Thanks,

Steve

Signature · 3 lines
Thanks,

Steve
#6 lore raw
In reply to Xiaoli Feng

I was looking in a little more detail at tests 213 and 228 ... and I see 228 passing to all servers I tried. Did you see a problem with that?

With 213 I see it working to Windows, and to Samba test 213 also works but only if "strict allocate = yes" is set in smb.conf (I just verified it on the buildbot)

Quoted 32 lines · Xiaoli Feng

Hello all,

Recently when I'm investigating the xfstests generic/213 generic/228 failures for cifs. Found that fallocate can't change the cifs disk space usage. Comparing xfs fileystem, fallocate can update space usage.

My tests is in 5.8.0-rc7+. I also file a bug for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=208775

# cat /etc/samba/smb.conf
[cifs]
path=/mnt/cifs
writeable=yes
# mount //localhost/cifs cifs -o user=root,password=redhat,cache=none,actimeo=0
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
#  fallocate -o 0 -l 2g /root/cifs/file1
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
]# ls -l cifs
total 1
-rwxr-xr-x. 1 root root 2147483648 Aug  2 21:57 file1

Thanks.

--
Best regards!
XiaoLi Feng 冯小丽

Signature · 3 lines
Thanks,

Steve
#7 lore raw

Hi,

----- Original Message -----

Quoted 9 lines

From: "Steve French" <[email protected]>
To: "Xiaoli Feng" <[email protected]>
Cc: "CIFS" <[email protected]>
Sent: Wednesday, August 5, 2020 1:39:43 AM
Subject: Re: fallocate can't change the cifs disk space usage

I was looking in a little more detail at tests 213 and 228 ... and I see 228 passing to all servers I tried. Did you see a problem with that?

Sorry, I made a mistake. I tested 228 in RHEL8 before. It's failed. Maybe it needs some patches. Now I re-test 228 in 5.8.0-rc7+. It's passed for both servers. And 213 is also passed if "strict allocate
= yes" is set. And now I met another issue for windows file server.
client is 5.8.0-rc7+.

# truncate -s 320k windows/file
# fallocate -o 2k -l 256k windows/file
fallocate: fallocate failed: Operation not supported
# fallocate -o 320k -l 256k windows/file
# 

Seems the offset for fallocate need beyond the size of truncate. But for xfs, it's passed. This test is base on test 255.

Quoted 50 lines

With 213 I see it working to Windows, and to Samba test 213 also works but only if "strict allocate = yes" is set in smb.conf (I just verified it on the buildbot)

Quoted 29 lines · Xiaoli Feng

Hello all,

Recently when I'm investigating the xfstests generic/213 generic/228 failures for cifs.
Found that fallocate can't change the cifs disk space usage. Comparing xfs fileystem,
fallocate can update space usage.

My tests is in 5.8.0-rc7+. I also file a bug for this issue.
https://bugzilla.kernel.org/show_bug.cgi?id=208775

# cat /etc/samba/smb.conf
[cifs]
path=/mnt/cifs
writeable=yes
# mount //localhost/cifs cifs -o
user=root,password=redhat,cache=none,actimeo=0
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
#  fallocate -o 0 -l 2g /root/cifs/file1
# df -h cifs
Filesystem        Size  Used Avail Use% Mounted on
//localhost/cifs   36G   23G   13G  66% /root/cifs
]# ls -l cifs
total 1
-rwxr-xr-x. 1 root root 2147483648 Aug  2 21:57 file1
Quoted 6 lines

Thanks.

--
Best regards!
XiaoLi Feng 冯小丽

--
Thanks,

Steve