Skip to contentSkip to conversation

CheckFS: Checkpoints and Block Level Incremental Backup (BLIB)

DISCUSSION Milind Dumbare 3 participants 4 messages Aug 1, 2005 – Aug 2, 2005

lore
Share & tools
lore
#0 lore raw

Hi,

The diff file generated by comparing ext3/ and
kernel/fs/checkfs/ can also be accessed from the link
http://checkfs.linsyssoft.com/temp/
I cleaned it, but still it has some unnecessary differences. I
am working on that to make it more clean and will send it to u as soon as I finish with that.

Milind Dumbare
(www.linsyssoft.com)

#1 lore raw
Quoted 8 lines · Milind Dumbare

Hi,

The diff file generated by comparing ext3/ and
kernel/fs/checkfs/ can also be accessed from the link
http://checkfs.linsyssoft.com/temp/
I cleaned it, but still it has some unnecessary differences. I
am working on that to make it more clean and will send it to u as soon as I finish with that.

Thanks for working on it; it's much appreciated. One very quick comment; it's generally considered poor form to remove other people's copyright notices; it's a do unto others as you would do unto them (lest their lawyers do unto you what your lawyers might do unto them if the positions were reversed :-) sort of thing.

- Ted

#2 lore raw

Hi,

This is just an intermediate diff between the original source and our source with checkfs replaced by ext3. We will be careful about maintaining the copyright notices when finishing this merge.

Thank you,
Milind Dumbare
(www.linsyssoft.com)

Quoted 19 lines · Theodore Ts'o
Quoted 8 lines · Milind Dumbare

Hi,

The diff file generated by comparing ext3/ and
kernel/fs/checkfs/ can also be accessed from the link
http://checkfs.linsyssoft.com/temp/
I cleaned it, but still it has some unnecessary differences. I
am working on that to make it more clean and will send it to u as soon as I finish with that.

Thanks for working on it; it's much appreciated. One very quick comment; it's generally considered poor form to remove other people's copyright notices; it's a do unto others as you would do unto them (lest their lawyers do unto you what your lawyers might do unto them if the positions were reversed :-) sort of thing.

- Ted

#3 lore raw
In reply to Milind Dumbare
Quoted 6 lines · Milind Dumbare

The diff file generated by comparing ext3/ and
kernel/fs/checkfs/ can also be accessed from the link
http://checkfs.linsyssoft.com/temp/
I cleaned it, but still it has some unnecessary differences. I
am working on that to make it more clean and will send it to u as soon as I finish with that.

As with Ted, I agree that there should never be copyright messages removed from the code, though I see you have said this will be fixed. I would also question the addition of new copyrights in files which do not contain any significant amount of LinSysSoft code.

The other comment is that it appears you are generating the diff against a different version of the ext3 code than the code with which you started (i.e. from a different kernel). This includes a large number of changes that are reverted in your code and makes it more difficult to see what has changed in the checkfs code vs. the core ext3 code. It would be preferrable to see the diffs against the version of ext3 from which it was originally branched.

I would also recommend that you maintain the same coding style as the rest of the ext3 code, if you are interested in having this added to the core Linux code.

Finally, it would appear that the diff is missing some bits of the code (e.g. changes to the header files where you declare the values of the ioctls and EXT3_COMPAT_FEATURE_HAS_CKPT).

I look forward to seeing your updated patch.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.