kill scsi_wait_req
PATCH 5/5 kill scsi_wait_req
cpqfc is the last user of scsi_wait_req. It is too broken to even test patches to convert it to other functions though. This patch just kills scsi_wait_req and adds to the list of things that are broken on cpqfc. I was not sure what the proper thing to do in this case when the driver
is so broken.
drivers/scsi/cpqfcTSinit.c +4 -0
@@ -663,6 +663,10 @@ int cpqfcTS_ioctl( struct scsi_device *S privatedata->pdrive = vendor_cmd->pdrive;// eventually gets us to our own _quecommand routine + +/* +* convert to scsi_execute_async if this driver ever works again +*/ scsi_wait_req(ScsiPassThruReq, &vendor_cmd->cdb[0], buf, vendor_cmd->len, 10*HZ, // timeout
drivers/scsi/scsi_lib.c +0 -49
55 lines not on this page · raw message
include/scsi/scsi_request.h +0 -3
@@ -47,9 +47,6 @@ struct scsi_request {extern struct scsi_request *scsi_allocate_request (struct scsi_device *,int );extern void scsi_release_request (struct scsi_request *); -extern void scsi_wait_req (struct scsi_request *,const void *cmnd, -void *buffer,unsigned bufflen, -int timeout,int retries); extern void scsi_do_req(struct scsi_request *, const void *cmnd, void *buffer, unsigned bufflen, void (*done) (struct scsi_cmnd *),
Quoted 6 lines · Mike Christie
cpqfc is the last user of
scsi_wait_req. It is too broken to even test patches to convert it to other functions though. This patch just killsscsi_wait_reqand adds to the list of things that are broken on cpqfc. I was not sure what the proper thing to do in this case when the driver
is so broken.
If you want to test it you'll find the needed patches on
http://opensource.sf-tec.de/kernel/. I found someone with this hardware (or he found me) and we're testing this.
If you refuse to touch it I'll try to fix it up once your patches went into mainline.
Eike
Quoted 10 lines · Rolf Eike Beer
Quoted 6 lines · Mike Christie
cpqfc is the last user of
scsi_wait_req. It is too broken to even test patches to convert it to other functions though. This patch just killsscsi_wait_reqand adds to the list of things that are broken on cpqfc. I was not sure what the proper thing to do in this case when the driver
is so broken.
Quoted 4 lines
If you want to test it you'll find the needed patches on http://opensource.sf-tec.de/kernel/. I found someone with this hardware (or he found me) and we're testing this.
If you refuse to touch it I'll try to fix it up once your patches went into mainline.
I actually had a patch. Let me see if I can dig it up so you can test.