Skip to contentSkip to conversation

dont retry on SG_IO tape commands

PATCH In review Mike Christie 1 participant 2 messages Sep 18, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dont retry on SG_IO tape commands

sd does not allow scsi_io_completion to retry commands for SG_IO requests, and it make sense that it should not happen for st SG_IO commands too. This patch returns to the block layer that the whole command completed and relies on the caller to check the request errors field.

Patch was made against scsi-rc-fixes.

drivers/scsi/st.c +1 -1
@@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
 
 static void st_intr(struct scsi_cmnd *SCpnt)
 {
-	scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
+	scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
 }
 
 /*
#1 lore raw

Actually forget this patch. We can just make scsi-ml handle this.

Quoted 28 lines · Mike Christie

sd does not allow scsi_io_completion to retry commands for SG_IO requests, and it make sense that it should not happen for st SG_IO commands too. This patch returns to the block layer that the whole command completed and relies on the caller to check the request errors field.

Patch was made against scsi-rc-fixes.

drivers/scsi/st.c +1 -2
@@ -4187,7 +4187,7 @@ static void scsi_tape_release(struct kre
 
 static void st_intr(struct scsi_cmnd *SCpnt)
 {
-	scsi_io_completion(SCpnt, (SCpnt->result ? 0: SCpnt->bufflen), 1);
+	scsi_io_completion(SCpnt, SCpnt->bufflen, 0);
 }
 
 /*
 
 
-

To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html