Skip to contentSkip to conversation

binutils breaks hppa kernel build, bad operands of fic, m

parisc-linux dann frazier 3 participants 5 messages Sep 24, 2005 1 message not in the archive

lore
Share & tools
lore
#1 lore raw

Re: [parisc-linux] binutils breaks hppa kernel build,

Quoted 2 lines

As discussed on irc:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=329888

This is a debian issue as far a I can tell. I tried

      fic,m           %r23(%sr3,%r26)

with GNU assembler 2.16.91 20050814 and I don't see a problem. However, I do see that we don't support the 2-bit space register form (PA 2.0).

Dave

Signature · 6 lines
J. David Anglin                                  [email protected]
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
#5 lore raw
In reply to dann frazier
Quoted 2 lines · dann frazier

As discussed on irc:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=329888

binutils-2.15 has this in include/opcodes/hppa.h:

{ "fdc",        0x04001280, 0xfc003fdf, "cZx(s,b)", pa10, 0},
{ "fdc",        0x04001280, 0xfc003fdf, "cZx(b)", pa10, 0},
{ "fic",        0x04000280, 0xfc001fdf, "cZx(S,b)", pa10, 0},
{ "fic",        0x04000280, 0xfc001fdf, "cZx(b)", pa10, 0},

And the binutils_2.16.1cvs20050902 version has only:

{ "fdc",        0x04001280, 0xfc00ffdf, "cZx(b)", pa10, 0},
{ "fdc",        0x04001280, 0xfc003fdf, "cZx(s,b)", pa10, 0},
{ "fic",        0x04000280, 0xfc001fdf, "cZx(S,b)", pa10, 0},

The order of the with 's' vs without 's' was switched and in the process dropped one "fic" line.

Can binutils maintainer/folks please just add it back in the new location?

Is the fix obvious enough or is a patch necessary?

thanks,
grant
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#2 lore raw

Re: [parisc-linux] binutils breaks hppa kernel build,

In reply to John David Anglin
Quoted 8 lines · John David Anglin
Quoted 2 lines

As discussed on irc:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=329888

This is a debian issue as far a I can tell. I tried

      fic,m           %r23(%sr3,%r26)

with GNU assembler 2.16.91 20050814 and I don't see a problem.

You are right - debian has a stale include file. The picked up this version of the opcode/hppa.h file:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/opcode/hppa.h.diff?r1=1.55&r2=1.56&cvsroot=src&f=h

Debian needs to pick up the TOB opcode/hppa.h and life will be good again.

thanks,
grant

Quoted 11 lines

However, I do see that we don't support the 2-bit space register form (PA 2.0).

Dave

Signature · 6 lines
J. David Anglin                                  [email protected]
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#4 lore raw

Re: [parisc-linux] binutils breaks hppa kernel build,

In reply to a message not in the archive
Quoted 11 lines · Grant Grundler
Quoted 8 lines · John David Anglin
Quoted 2 lines

As discussed on irc:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=329888

This is a debian issue as far a I can tell. I tried

      fic,m           %r23(%sr3,%r26)

with GNU assembler 2.16.91 20050814 and I don't see a problem.

You are right - debian has a stale include file.

Sorry - I was wrong too.

I confused the bug report with a related problem on unstable kernel builds:
...
AS arch/parisc/kernel/pacache.o
arch/parisc/kernel/pacache.S: Assembler messages:
arch/parisc/kernel/pacache.S:952: Error: Invalid operands arch/parisc/kernel/pacache.S:953: Error: Invalid operands arch/parisc/kernel/pacache.S:954: Error: Invalid operands
...

Where line 952/953/etc are this format:

1:      fic,m           %r23(%r26)
        fic,m           %r23(%r26)
        fic,m           %r23(%r26)
Quoted 2 lines

The picked up this version of the opcode/hppa.h file:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/include/opcode/hppa.h.diff?r1=1.55&r2=1.56&cvsroot=src&f=h

I'm pretty sure this diff introduces the error I saw.

Quoted 1 line

Debian needs to pick up the TOB opcode/hppa.h and life will be good again.

Sorry - my bad again. TOB opcode/hppa.h is missing one variant of "fic" as I mentioned in previous email. I had it right the first time around.

apologies for the confusion and hope this clarifies, grant
_______________________________________________
parisc-linux mailing list [email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux