85xx PHY Platform Update

PATCH In review info 3 participants 3 messages Oct 24, 2005

lore

Share & tools

lore

info

author

2005-10-24 14:49 UTC #0 lore raw

PATCH 1/1 85xx PHY Platform Update

Andy, Kumar

I try this patch for RMC-G8500 from GDAtech, error message below:
---------------------------------------------------------------------------------
[root@ppclinux linux-2.6.13]# make uImage

  CHK     include/linux/version.h
  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  CC      drivers/net/gianfar.o

drivers/net/gianfar.c: In function `gfar_probe':
drivers/net/gianfar.c:217: error: structure has no member named phy_reg_addr' drivers/net/gianfar.c: In function init_phy':
drivers/net/gianfar.c:452: error: structure has no member named phyid' drivers/net/gianfar.c: In function stop_gfar':
drivers/net/gianfar.c:636: error: structure has no member named interruptPHY' drivers/net/gianfar.c: In function gfar_phy_startup_timer':
drivers/net/gianfar.c:1818: error: structure has no member named interruptPHY' drivers/net/gianfar.c:1826: error: structure has no member named interruptPHY' make[2]: *** [drivers/net/gianfar.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

---------------------------------------------------------------------------------
because???

/* Internal interrupts are all Level Sensitive, and Positive Polarity */

include/linux/fsl_devices.h +3 -5

@@ -47,14 +47,19 @@
 struct gianfar_platform_data {
 	/* device specific information */
 	u32 device_flags;
-	u32 phy_reg_addr;
 
 	/* board specific information */
 	u32 board_flags;
-	u32 phy_flags;
-	u32 phyid;
-	u32 interruptPHY;
+	const char *bus_id;
 	u8 mac_addr[6];
+};
+
 
 
-------------------------------------------------------------------------------------------

<This patch updates the 85xx platform code to support the new PHY Layer.
<
<Signed-off-by: Andy Fleming <afleming at freescale.com>
<Signed-off-by: Kumar Gala <Kumar.gala at freescale.com>
<
<
<diff --git a/arch/ppc/platforms/85xx/mpc8540_ads.c b/arch/ppc/platforms/85xx/mpc8540_ads.c <--- a/arch/ppc/platforms/85xx/mpc8540_ads.c
<+++ b/arch/ppc/platforms/85xx/mpc8540_ads.c
<@@ -53,6 +53,10 @@
<
< #include <syslib/ppc85xx_setup.h>
<
<+static const char *GFAR_PHY_0 = "phy0:0";
<+static const char *GFAR_PHY_1 = "phy0:1";
<+static const char *GFAR_PHY_3 = "phy0:3";
<+
< /* ************************************************************************ < *
< * Setup the architecture
<@@ -64,6 +68,7 @@ mpc8540ads_setup_arch(void)

Vitaly Bordug

2005-10-24 15:10 UTC #1 lore raw

Quoted 22 lines · info

Andy, Kumar
I try this patch for RMC-G8500 from GDAtech, error message below:
---------------------------------------------------------------------------------
[root@ppclinux linux-2.6.13]# make uImage
  CHK     include/linux/version.h
  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  CC      drivers/net/gianfar.o
drivers/net/gianfar.c: In function `gfar_probe':
drivers/net/gianfar.c:217: error: structure has no member named phy_reg_addr' drivers/net/gianfar.c: In function init_phy':
drivers/net/gianfar.c:452: error: structure has no member named phyid' drivers/net/gianfar.c: In function stop_gfar':
drivers/net/gianfar.c:636: error: structure has no member named interruptPHY' drivers/net/gianfar.c: In function gfar_phy_startup_timer':
drivers/net/gianfar.c:1818: error: structure has no member named interruptPHY' drivers/net/gianfar.c:1826: error: structure has no member named interruptPHY' make[2]: *** [drivers/net/gianfar.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Quoted 2 lines

---------------------------------------------------------------------------------
because???

This patch implies that PAL (Phy Abstraction layer) is utilized within the gianfar driver, but this change is just queued upstream (AFAIK - or in the netdev tree) right now. In order to use this you should wait a little...

Quoted 53 lines

/* Internal interrupts are all Level Sensitive, and Positive Polarity */
include/linux/fsl_devices.h +3 -5
@@ -47,14 +47,19 @@
 struct gianfar_platform_data {
 	/* device specific information */
 	u32 device_flags;
-	u32 phy_reg_addr;
 
 	/* board specific information */
 	u32 board_flags;
-	u32 phy_flags;
-	u32 phyid;
-	u32 interruptPHY;
+	const char *bus_id;
 	u8 mac_addr[6];
+};
+
 
 
-------------------------------------------------------------------------------------------
<This patch updates the 85xx platform code to support the new PHY Layer.
<
<Signed-off-by: Andy Fleming <afleming at freescale.com>
<Signed-off-by: Kumar Gala <Kumar.gala at freescale.com>
<
<
<diff --git a/arch/ppc/platforms/85xx/mpc8540_ads.c b/arch/ppc/platforms/85xx/mpc8540_ads.c <--- a/arch/ppc/platforms/85xx/mpc8540_ads.c
<+++ b/arch/ppc/platforms/85xx/mpc8540_ads.c
<@@ -53,6 +53,10 @@
<
< #include <syslib/ppc85xx_setup.h>
<
<+static const char *GFAR_PHY_0 = "phy0:0";
<+static const char *GFAR_PHY_1 = "phy0:1";
<+static const char *GFAR_PHY_3 = "phy0:3";
<+
< /* ************************************************************************ < *
< * Setup the architecture
<@@ -64,6 +68,7 @@ mpc8540ads_setup_arch(void)
_______________________________________________
Linuxppc-embedded mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Signature · 2 lines

Sincerely,
Vitaly

Kumar Gala

2005-10-24 22:03 UTC #2 lore raw

In reply to info

You need the corresponding patches that are in the netdev tree for the PHY subsystem.

- kumar

Quoted 80 lines · info

Andy, Kumar
I try this patch for RMC-G8500 from GDAtech, error message below:
----------------------------------------------------------------------
-----------
[root@ppclinux linux-2.6.13]# make uImage
  CHK     include/linux/version.h
  CHK     include/linux/compile.h
  CHK     usr/initramfs_list
  CC      drivers/net/gianfar.o
drivers/net/gianfar.c: In function `gfar_probe':
drivers/net/gianfar.c:217: error: structure has no member named phy_reg_addr' drivers/net/gianfar.c: In function init_phy':
drivers/net/gianfar.c:452: error: structure has no member named phyid' drivers/net/gianfar.c: In function stop_gfar':
drivers/net/gianfar.c:636: error: structure has no member named interruptPHY' drivers/net/gianfar.c: In function gfar_phy_startup_timer':
drivers/net/gianfar.c:1818: error: structure has no member named interruptPHY' drivers/net/gianfar.c:1826: error: structure has no member named interruptPHY' make[2]: *** [drivers/net/gianfar.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
----------------------------------------------------------------------
-----------
because???
/* Internal interrupts are all Level Sensitive, and Positive
Polarity */
include/linux/fsl_devices.h +3 -6
@@ -47,14 +47,19 @@
 struct gianfar_platform_data {
     /* device specific information */
     u32 device_flags;
-    u32 phy_reg_addr;
 
     /* board specific information */
     u32 board_flags;
-    u32 phy_flags;
-    u32 phyid;
-    u32 interruptPHY;
+    const char *bus_id;
     u8 mac_addr[6];
+};
+
 
 
---------------------------------------------------------------------- 
---------------------
<This patch updates the 85xx platform code to support the new PHY Layer.
<
<Signed-off-by: Andy Fleming <afleming at freescale.com>
<Signed-off-by: Kumar Gala <Kumar.gala at freescale.com>
<
<
<diff --git a/arch/ppc/platforms/85xx/mpc8540_ads.c b/arch/ppc/platforms/85xx/mpc8540_ads.c <--- a/arch/ppc/platforms/85xx/mpc8540_ads.c
<+++ b/arch/ppc/platforms/85xx/mpc8540_ads.c
<@@ -53,6 +53,10 @@
<
< #include <syslib/ppc85xx_setup.h>
<
<+static const char *GFAR_PHY_0 = "phy0:0";
<+static const char *GFAR_PHY_1 = "phy0:1";
<+static const char *GFAR_PHY_3 = "phy0:3";
<+
< /* ************************************************************************ < *
< * Setup the architecture
<@@ -64,6 +68,7 @@ mpc8540ads_setup_arch(void)
_______________________________________________
Linuxppc-embedded mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-embedded