Skip to contentSkip to conversation

i2c: ds1337 BCD conversion fix

PATCH New Greg KH 1 participant 1 message Nov 8, 2005

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 i2c: ds1337 BCD conversion fix

[PATCH] i2c: ds1337 BCD conversion fix

Fix BCD value errors when month=9, moving the increment inside the BIN2BCD macro.
Fix similar code for the weekday value, just for consistency.

This bug was reported by Michael Burian <[email protected]>.

---
commit ef9627464490fe67235bbd5724d55345b92c0315
tree 62ddcf3b6eaac8c723a09ab174c4afe330c135a3
parent a852daa00ad91350fe603da47becaf3d5af4f2bd
author James Chapman <[email protected]> Sun, 06 Nov 2005 23:07:38 +0100 committer Greg Kroah-Hartman <[email protected]> Mon, 07 Nov 2005 21:46:37 -0800

 drivers/i2c/chips/ds1337.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/chips/ds1337.c +2 -2
index 01b0370..02682fb 100644
@@ -164,9 +164,9 @@ static int ds1337_set_datetime(struct i2
 	buf[1] = BIN2BCD(dt->tm_sec);
 	buf[2] = BIN2BCD(dt->tm_min);
 	buf[3] = BIN2BCD(dt->tm_hour);
-	buf[4] = BIN2BCD(dt->tm_wday) + 1;
+	buf[4] = BIN2BCD(dt->tm_wday + 1);
 	buf[5] = BIN2BCD(dt->tm_mday);
-	buf[6] = BIN2BCD(dt->tm_mon) + 1;
+	buf[6] = BIN2BCD(dt->tm_mon + 1);
 	val = dt->tm_year;
 	if (val >= 100) {
 		val -= 100;