Skip to contentSkip to conversation

update ide.c to use pci_get_drvdata()

PATCH In review Kasper Sandberg 2 participants 2 messages Nov 16, 2005 – Nov 18, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 update ide.c to use pci_get_drvdata()

This updates drivers/ide/ide.c to use pci_get_drvdata() instead of accessing driver_data directly.

drivers/ide/ide.c +2 -2
diff -Naur linux-2.6.15-rc1-git4-a/drivers/ide/ide.c linux-2.6.15-rc1-git4-b/drivers/ide/ide.c
@@ -1216,7 +1216,7 @@
 
 static int generic_ide_suspend(struct device *dev, pm_message_t state)
 {
-	ide_drive_t *drive = dev->driver_data;
+	ide_drive_t *drive = pci_get_drvdata(dev);
 	struct request rq;
 	struct request_pm_state rqpm;
 	ide_task_t args;
@@ -1235,7 +1235,7 @@
 
 static int generic_ide_resume(struct device *dev)
 {
-	ide_drive_t *drive = dev->driver_data;
+	ide_drive_t *drive = pci_get_drvdata(dev);
 	struct request rq;
 	struct request_pm_state rqpm;
 	ide_task_t args;
#1 lore raw

[ akpm and linus removed from cc: ]

Quoted 4 lines · Kasper Sandberg

This updates drivers/ide/ide.c to use pci_get_drvdata() instead of accessing driver_data directly.

diff -Naur linux-2.6.15-rc1-git4-a/drivers/ide/ide.c linux-2.6.15-rc1-git4-b/drivers/ide/ide.c
--- linux-2.6.15-rc1-git4-a/drivers/ide/ide.c 2005-11-16
22:50:43.700117269 +0100
+++ linux-2.6.15-rc1-git4-b/drivers/ide/ide.c 2005-11-16
23:00:43.891060658 +0100
@@ -1216,7 +1216,7 @@

static int generic_ide_suspend(struct device *dev, pm_message_t state) {
- ide_drive_t *drive = dev->driver_data;
+ ide_drive_t *drive = pci_get_drvdata(dev);

dev is of "struct device *" type not "struct pci_dev *" so dev_get_drvdata() should be used instead

struct request rq;
struct request_pm_state rqpm;
ide_task_t args;
@@ -1235,7 +1235,7 @@

static int generic_ide_resume(struct device *dev) {
- ide_drive_t *drive = dev->driver_data;
+ ide_drive_t *drive = pci_get_drvdata(dev);

ditto

struct request rq;
struct request_pm_state rqpm;
ide_task_t args;

Care to respin the patch?

[ Am I the only one reviewing IDE patches? It seems so... ]

Bartlomiej