Skip to contentSkip to conversation

make otherend_changed entrypoint optional for xenbus devices

PATCH Applied harry 2 participants 2 messages Nov 17, 2005

lore
Share & tools
lore

harry

author
#0 lore raw

PATCH 1/1 make otherend_changed entrypoint optional for xenbus devices

Ewan,

Here's the patch for making the otherend_changed entrypoint
optional. The USB driver doesn't need this entrypoint because the state machine driven by it is factored out of the driver code entirely into xenidc.

This is a resend. I forgot to put [PATCH] in the subject line last
time.

diff -r 595ef1ab007c -r 2089b7edcada linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c
--- a/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c Tue Nov
15 14:44:59 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c Tue Nov
15 16:43:02 2005
@@ -299,8 +299,8 @@

        DPRINTK("state is %d, %s, %s",
                state, dev->otherend_watch.node, vec[XS_WATCH_PATH]);

-
- drv->otherend_changed(dev, state);
+ if (drv->otherend_changed)
+ drv->otherend_changed(dev, state);
}

linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c +2 -2
diff -r 595ef1ab007c -r 2089b7edcada linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_probe.c
@@ -299,8 +299,8 @@
 
 	DPRINTK("state is %d, %s, %s",
 		state, dev->otherend_watch.node, vec[XS_WATCH_PATH]);
-
-	drv->otherend_changed(dev, state);
+	if (drv->otherend_changed)
+		drv->otherend_changed(dev, state);
 }
 
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 6 lines · harry

Ewan,

Here's the patch for making the otherend_changed entrypoint
optional. The USB driver doesn't need this entrypoint because the state machine driven by it is factored out of the driver code entirely into xenidc.

Applied, thanks. Sorry I missed it last time around.

Ewan.