Skip to contentSkip to conversation

: Do not register from callout

RFC PATCH New Chandra Seetharaman 1 participant 1 message Nov 19, 2005

lore
Share & tools
lore

Chandra Seetharaman

author
#0 lore raw

RFC PATCH 6/7 : Do not register from callout

dcdbas re-registers itself from within the callout. This is incorrect in two respects:

1. Callout should not register/unregister.
2. It re-registers while the block is still in the list, which would corrupt the list.

This patch fixes the problem by registering the callout to be the last one to be called when the event happens.

Signed-off-by Chandra Seetharaman <[email protected]>
Signed-off-by Alan Stern <[email protected]>

-----

 drivers/firmware/dcdbas.c |   19 ++++---------------
 1 files changed, 4 insertions(+), 15 deletions(-)
drivers/firmware/dcdbas.c +4 -15
Index: l2615-rc1-notifiers/drivers/firmware/dcdbas.c
===================================================================
@@ -483,26 +483,15 @@ static void dcdbas_host_control(void)
 static int dcdbas_reboot_notify(struct notifier_block *nb, unsigned long code,
 				void *unused)
 {
-	static unsigned int notify_cnt = 0;
-
 	switch (code) {
 	case SYS_DOWN:
 	case SYS_HALT:
 	case SYS_POWER_OFF:
 		if (host_control_on_shutdown) {
 			/* firmware is going to perform host control action */
-			if (++notify_cnt == 2) {
-				printk(KERN_WARNING
-				       "Please wait for shutdown "
-				       "action to complete...\n");
-				dcdbas_host_control();
-			}
-			/*
-			 * register again and initiate the host control
-			 * action on the second notification to allow
-			 * everyone that registered to be notified
-			 */
-			register_reboot_notifier(nb);
+			printk(KERN_WARNING "Please wait for shutdown "
+			       "action to complete...\n");
+			dcdbas_host_control();
 		}
 		break;
 	}

@@ -513,7 +502,7 @@ static int dcdbas_reboot_notify(struct n
 static struct notifier_block dcdbas_reboot_nb = {
 	.notifier_call = dcdbas_reboot_notify,
 	.next = NULL,
-	.priority = 0
+	.priority = INT_MIN
 };
 
 static DCDBAS_BIN_ATTR_RW(smi_data);
Signature · 4 lines
----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - [email protected]   |      .......you may get it.
----------------------------------------------------------------------