stable review patch - ALSA ALC800 codec
This fixes an apparent copy and paste bug that has really been causing problems for a lot of users. It closes ~10 different ALSA bug reports, see #1563 for example. Please apply ASAP for -stable.
Lee
This patch is to fix the problem of calculating the nid incorrectly when auto-probe for ALC880. The problem to be fixed often behaves with such words when using dmesg, 'num_steps = 0 for NID=0x8' when auto-probe for ALC880.
The patch contains:
- alsa-kernel/pci/hda/patch_realtek.c: replace 'alc880_dac_to_idx' with 'alc880_idx_to_dac' in function 'alc880_auto_fill_dac_nids()'
alsa-kernel/pci/hda/patch_realtek.c +1 -1
@@ -1809,7 +1809,7 @@ nid = cfg->line_out_pins[i];if (alc880_is_fixed_pin (nid)) {int idx =alc880_fixed_pin_idx (nid); - spec->multiout.dac_nids[i] =alc880_dac_to_idx (idx); + spec->multiout.dac_nids[i] =alc880_idx_to_dac (idx); assigned[idx] =1 ; } }
Quoted 3 lines · * Lee Revell ([email protected]) wrote:
This fixes an apparent copy and paste bug that has really been causing problems for a lot of users. It closes ~10 different ALSA bug reports, see #1563 for example. Please apply ASAP for -stable.
Please resend when this is fixed in Linus' tree. Also, some patch nitpicks...make sure to add From: line to first line of changelog comments to keep proper authorship when you are forwarding someone else's patch, and make sure it applies to kernel tree please (s/alsa-kernel/sound/ for example).
thanks,
-chris