Skip to contentSkip to conversation

stack overflow safe kdump (i386) - do_nmi

PATCH In review Fernando Luis Vazquez Cao 1 participant 1 message Nov 28, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 stack overflow safe kdump (i386) - do_nmi

crash_nmi_callback is called right after a system crash which might have caused by stack overflow, thus smp_processor_id should not be trusted. Use the safe replacement safe_smp_processor_id.

---

diff -urNp linux-2.6.15-rc2/arch/i386/kernel/traps.c linux-2.6.15-rc2-sov/arch/i386/kernel/traps.c
--- linux-2.6.15-rc2/arch/i386/kernel/traps.c 2005-11-29
01:46:34.000000000 +0900
+++ linux-2.6.15-rc2-sov/arch/i386/kernel/traps.c 2005-11-29
01:52:17.000000000 +0900
@@ -648,7 +648,7 @@ fastcall void do_nmi(struct pt_regs * re

nmi_enter();

- cpu = smp_processor_id();
+ cpu = safe_smp_processor_id();

#ifdef CONFIG_HOTPLUG_CPU
if (!cpu_online(cpu)) {