Skip to contentSkip to conversation

setting irq affinity is broken in ia32 with MSI enabled

PATCH In review Shaohua Li 2 participants 2 messages Nov 30, 2005

lore
Share & tools
lore

Shaohua Li

author
#0 lore raw

PATCH 1/1 setting irq affinity is broken in ia32 with MSI enabled

Setting irq affinity stops working when MSI is enabled. With MSI, move_irq is empty, so we can't change irq affinity. It appears a typo in Ashok's original commit for this issue. X86_64 actually is using move_native_irq.

arch/i386/kernel/io_apic.c +2 -2
@@ -2009,7 +2009,7 @@ static void ack_edge_ioapic_vector(unsig
 {
 	int irq = vector_to_irq(vector);
 
-	move_irq(vector);
+	move_native_irq(vector);
 	ack_edge_ioapic_irq(irq);
 }
 
@@ -2024,7 +2024,7 @@ static void end_level_ioapic_vector (uns
 {
 	int irq = vector_to_irq(vector);
 
-	move_irq(vector);
+	move_native_irq(vector);
 	end_level_ioapic_irq(irq);
 }
 
#1 lore raw
Quoted 6 lines · Shaohua Li

Setting irq affinity stops working when MSI is enabled. With MSI, move_irq is empty, so we can't change irq affinity. It appears a typo in Ashok's original commit for this issue. X86_64 actually is using move_native_irq.

Yep...Think i missed the MSI/i386 case.

Looks good

Ashok Raj