PATCH: Fix typos, exclamation mark frenzy and missing device id on messages
Subsystems (2)
I sent this out a couple of months ago and the driver author said it he'd merge it. Nothing has happened since so I'm submitting it directly.
No functionality changes just texts.
Signed-off-by Alan Cox <[email protected]>
drivers/char/tlclk.c +7 -8
@@ -211,7 +211,7 @@ result =request_irq (telclk_interrupt, &tlclk_interrupt,SA_INTERRUPT ,"telco_clock" , tlclk_interrupt);if (result == -EBUSY ) { -printk (KERN_ERR "telco_clock: Interrupt can't be reserved!\n" ); +printk (KERN_ERR "telco_clock: Interrupt can't be reserved.\n" );return -EBUSY ; }inb (TLCLK_REG6 );/* Clear interrupt events */
@@ -741,7 +741,7 @@ ret =register_chrdev (tlclk_major,"telco_clock" , &tlclk_fops);if (ret <0 ) { -printk (KERN_ERR "telco_clock: can't get major! %d\n" , tlclk_major); +printk (KERN_ERR "tlclk: can't get major %d.\n" , tlclk_major);return ret; } alarm_events =kzalloc (sizeof (struct tlclk_alarms ),GFP_KERNEL );
@@ -750,7 +750,7 @@/* Read telecom clock IRQ number (Set by BIOS) */ if (!request_region (TLCLK_BASE ,8 ,"telco_clock" )) { -printk (KERN_ERR "tlclk: request_region failed! 0x%X\n" , +printk (KERN_ERR "tlclk: request_region 0x%X failed.\n" ,TLCLK_BASE ); ret = -EBUSY ; goto out2;
@@ -758,7 +758,7 @@ telclk_interrupt = (inb (TLCLK_REG7 ) &0x0f );if (0x0F == telclk_interrupt ) {/* not MCPBL0010 ? */ -printk (KERN_ERR "telclk_interrup = 0x%x non-mcpbl0010 hw\n" , +printk (KERN_ERR "telclk_interrup = 0x%x non-mcpbl0010 hw.\n" , telclk_interrupt); ret = -ENXIO ; goto out3;
@@ -768,7 +768,7 @@ ret =misc_register (&tlclk_miscdev);if (ret <0 ) { -printk (KERN_ERR " misc_register retruns %d\n" , ret); +printk (KERN_ERR "tlclk: misc_register returns %d.\n" , ret); ret = -EBUSY ; goto out3; }
@@ -776,8 +776,7 @@ tlclk_device =platform_device_register_simple ("telco_clock" ,-1 ,NULL ,0 );if (!tlclk_device) { -printk (KERN_ERR " platform_device_register retruns 0x%X\n" , - (unsigned int ) tlclk_device); +printk (KERN_ERR "tlclk: platform_device_register failed.\n" ); ret = -EBUSY ; goto out4; }
@@ -785,7 +784,7 @@ ret =sysfs_create_group (&tlclk_device->dev.kobj, &tlclk_attribute_group);if (ret) { -printk (KERN_ERR "failed to create sysfs device attributes\n" ); +printk (KERN_ERR "tlclk: failed to create sysfs device attributes.\n" );sysfs_remove_group (&tlclk_device->dev.kobj, &tlclk_attribute_group); goto out5;
drivers/char/tlclk.c line 214
Quoted 13 lines · Alan Cox
I sent this out a couple of months ago and the driver author said it he'd merge it. Nothing has happened since so I'm submitting it directly.
No functionality changes just texts.
+++
linux-2.6.15-mm2/drivers/char/tlclk.c2006-01-09 14:40:29.000000000 +0000drivers/char/tlclk.c +1
-1@@ -211,7 +211,7 @@ result =request_irq (telclk_interrupt, &tlclk_interrupt,SA_INTERRUPT ,"telco_clock" , tlclk_interrupt);if (result == -EBUSY ) { -printk (KERN_ERR "telco_clock: Interrupt can't be reserved!\n" ); +printk (KERN_ERR "telco_clock: Interrupt can't be reserved.\n" );
You changed all the other telco_clock's to tlclk's but this one.
Dave