Subject: [PATCH] Git ignore generated files in sub-directory tools.
---
tools/.gitignore | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 tools/.gitignore
ee1b1a7ee4f4b7540c8a016e41cb653ea20b8427
tools/.gitignore new file +10 -0
@@ -0,0 +1,10 @@ +# +# Generated files +# +bmp_logo +crc32.c +envcrc +environment.c +gen_eth_addr +img2srec +mkimage
Signature · 1 line
0.99.9n
Quoted 24 lines · In message <[email protected]> you wrote:
tools/.gitignore | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 tools/.gitignore
ee1b1a7ee4f4b7540c8a016e41cb653ea20b8427tools/.gitignore new file +10
-0@@ -0,0 +1,10 @@ +# +# Generated files +# +bmp_logo +crc32.c +envcrc +environment.c +gen_eth_addr +img2srec +mkimageSignature · 1 line
0.99.9n
What is this good for? All these files go aways when your run a make mrproper ?
Best regards,
Wolfgang Denk
Signature · 3 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Intel's new motto: United we stand. Divided we fall!
Quoted 20 lines · Wolfgang Denk
Quoted 19 lines · In message <[email protected]> you wrote:
tools/.gitignore | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 tools/.gitignore
ee1b1a7ee4f4b7540c8a016e41cb653ea20b8427tools/.gitignore new file +7
-0@@ -0,0 +1,10 @@ +# +# Generated files +# +bmp_logo +crc32.c +envcrc +environment.c
Quoted 8 lines
Quoted 5 lines
tools/.gitignore new file +3
-0+gen_eth_addr +img2srec +mkimageSignature · 1 line
0.99.9nWhat is this good for? All these files go aways when your run a make mrproper ?
True. But the interesting command before that is usually "git status", where they show up, but should not ever be checked in. Separate concept that cleaning; just like the .gitignore for .o, System.map, etc, at the top level. (Kumar's posted PATCH a few days ago.)
jdl
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 3 lines
What is this good for? All these files go aways when your run a make mrproper ?
True. But the interesting command before that is usually "git status", where they show up, but should not ever be checked in. Separate concept that cleaning;
Correct. And this is why I reject this patch: I use exactly this mechanism to verify that "make mrproper" really cleans up everything it is expected to clean.
Quoted 2 lines
just like the .gitignore for .o, System.map, etc, at the top level. (Kumar's posted PATCH a few days ago.)
...which I will probably reject for the very same reason, too.
Best regards,
Wolfgang Denk
Signature · 3 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If God had a beard, he'd be a UNIX programmer.
Quoted 5 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 3 lines
What is this good for? All these files go aways when your run a make mrproper ?
Quoted 7 lines
Quoted 3 lines
True. But the interesting command before that is usually "git status", where they show up, but should not ever be checked in. Separate concept that cleaning;
Correct. And this is why I reject this patch: I use exactly this mechanism to verify that "make mrproper" really cleans up everything it is expected to clean.
[Old thread...]
git ls-files -o does a better job identifying stale files. git status is useful during a normal development practice where you do not want to see loads of .o files that you know are there, but just want to see that nothing new stuff is hanging around.
Sam
Quoted 2 lines · In message <[email protected]> you wrote:
git ls-files -o does a better job identifying stale files.
Maybe. But I did not talk about stale files.
Quoted 1 line
git status is useful during a normal development practice where you do
Define "normal". It seems to mean different things for you and me.
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ernest asks Frank how long he has been working for the company.
"Ever since they threatened to fire me."Quoted 9 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:
git ls-files -o does a better job identifying stale files.
Maybe. But I did not talk about stale files.
Quoted 1 line
git status is useful during a normal development practice where you do
Define "normal". It seems to mean different things for you and me.
Consider you add a new driver to u-boot.
This includes modifying top-lvel README, a Makefile and you add two new files.
If all files created during a build are included in .gitignore files then if you issue: 'git status' at any point in time (no need to run mrproper) you will get an overview over:
- modified files
- new files (listed as untracked files)
and more importanly the git status output is not cluttered with a lot of 'build noise'.
If you then like to check the properness of make mrproper you issue 'make mrproper' and then what was not cleaned by 'make mrproper' shows up with 'git ls-files-o'.
Hope this clarified my comment.
Sam
Quoted 8 lines · In message <[email protected]> you wrote:
If all files created during a build are included in .gitignore files then if you issue: 'git status' at any point in time (no need to run mrproper) you will get an overview over:
- modified files
- new files (listed as untracked files)
and more importanly the git status output is not cluttered with a lot of 'build noise'.
What prevents you from running "make mrproper" before running "git status" ?
This gives you the *additional* bebefit to see if any of your Makefiles misses to clean some files...
Quoted 3 lines
If you then like to check the properness of make mrproper you issue 'make mrproper' and then what was not cleaned by 'make mrproper' shows up with 'git ls-files-o'.
-> git ls-files-o
git: 'ls-files-o' is not a git-command
;-)
TIMTOWTDI...
I don't see any significant benefit. It's simply not worth the time.
Best regards,
Wolfgang Denk
Signature · 5 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de NOTE: The Most Fundamental Particles in This Product Are Held Together by a "Gluing" Force About Which Little is Currently Known and Whose Adhesive Power Can Therefore Not Be Permanently Guaranteed.
Quoted 3 lines
What prevents you from running "make mrproper" before running "git status" ?
Build time. Now I work with the kernel in various confg where this equals to some amount time so it matters. I dunno about u-boot, long time since I build U-boot.
Quoted 6 lines
Quoted 3 lines
If you then like to check the properness of make mrproper you issue 'make mrproper' and then what was not cleaned by 'make mrproper' shows up with 'git ls-files-o'.
-> git ls-files-o
git: 'ls-files-o' is not a git-command
git ls-files -o
Sam