Skip to contentSkip to conversation

BUG_ON() Conversion in input/serio/hil_mlc.c

PATCH New Eric Sesterhenn / snakebyte 1 participant 1 message Jan 26, 2006

Subsystems (2)
Kernel janitors Input drivers
lore
Share & tools
lore

Eric Sesterhenn / snakebyte

author
#0 lore raw

PATCH 1/2 BUG_ON() Conversion in input/serio/hil_mlc.c

hi,

this changes if() BUG(); constructs to BUG_ON() which is cleaner and can better optimized away

Signed-off-by Eric Sesterhenn <[email protected]>
drivers/input/serio/hil_mlc.c renamed from drivers/input/serio/hil_mlc.c.orig +1 -1
@@ -556,7 +556,7 @@ static inline void hilse_setup_input(hil
 	do_gettimeofday(&(mlc->instart));
 	mlc->icount = 15;
 	memset(mlc->ipacket, 0, 16 * sizeof(hil_packet));
-	if (down_trylock(&(mlc->isem))) BUG();
+	BUG_ON(down_trylock(&(mlc->isem)));
 
 	return;
 }

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors