BUG_ON() Conversion in input/serio/hp_sdc_mlc.c
Subsystems (3)
PATCH 2/2 BUG_ON() Conversion in input/serio/hp_sdc_mlc.c
hi,
this changes if() BUG(); constructs to BUG_ON() which is cleaner and can better optimized away
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/input/serio/hp_sdc_mlc.c renamed from drivers/input/serio/hp_sdc_mlc.c.orig +4 -3
@@ -270,9 +270,10 @@ static void hp_sdc_mlc_out (hil_mlc *mlc do_control: priv->emtestmode = mlc->opacket &HIL_CTRL_TEST ; -if ((mlc->opacket & (HIL_CTRL_APE |HIL_CTRL_IPF )) ==HIL_CTRL_APE ) { -BUG ();/* we cannot emulate this, it should not be used. */ - } + +/* we cannot emulate this, it should not be used. */ +BUG_ON ((mlc->opacket & (HIL_CTRL_APE |HIL_CTRL_IPF )) ==HIL_CTRL_APE ); +if ((mlc->opacket &HIL_CTRL_ONLY ) ==HIL_CTRL_ONLY ) goto control_only;if (mlc->opacket &HIL_CTRL_APE ) {BUG ();/* Should not send command/data after engaging APE */
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors