Skip to contentSkip to conversation

BUG_ON() Conversion in fs/dquot.c

PATCH New Eric Sesterhenn / snakebyte 1 participant 1 message Jan 26, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/8 BUG_ON() Conversion in fs/dquot.c

hi,

this changes if() BUG(); constructs to BUG_ON() which is cleaner and can better optimized away

fs/dquot.c renamed from fs/dquot.c.orig +3 -6
@@ -420,8 +420,7 @@ static void invalidate_dquots(struct sup
 		if (dquot->dq_type != type)
 			continue;
 #ifdef __DQUOT_PARANOIA
-		if (atomic_read(&dquot->dq_count))
-			BUG();
+		BUG_ON(atomic_read(&dquot->dq_count));
 #endif
 		/* Quota now has no users and it has been written on last dqput() */
 		remove_dquot_hash(dquot);
@@ -560,8 +559,7 @@ we_slept:
 	atomic_dec(&dquot->dq_count);
 #ifdef __DQUOT_PARANOIA
 	/* sanity check */
-	if (!list_empty(&dquot->dq_free))
-		BUG();
+	BUG_ON(!list_empty(&dquot->dq_free));
 #endif
 	put_dquot_last(dquot);
 	spin_unlock(&dq_list_lock);
@@ -635,8 +633,7 @@ we_slept:
 		return NODQUOT;
 	}
 #ifdef __DQUOT_PARANOIA
-	if (!dquot->dq_sb)	/* Has somebody invalidated entry under us? */
-		BUG();
+	BUG_ON(!dquot->dq_sb);	/* Has somebody invalidated entry under us? */
 #endif
 
 	return dquot;

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors