BUG_ON() Conversion in fs/hfsplus/
Subsystems (2)
PATCH 5/12 BUG_ON() Conversion in fs/hfsplus/
hi,
this changes if() BUG(); constructs to BUG_ON() which is cleaner, contains unlikely() and can better optimized away.
Signed-off-by Eric Sesterhenn <[email protected]>
fs/hfsplus/bnode.c renamed from fs/hfsplus/bnode.c.orig +2 -4
@@ -466,8 +466,7 @@ void hfs_bnode_unhash(struct hfs_bnode *for (p = &node->tree->node_hash[hfs_bnode_hash (node->this)]; *p && *p != node; p = &(*p)->next_hash) ; -if (!*p) -BUG (); +BUG_ON (!*p); *p = node->next_hash; node->tree->node_hash_cnt--; }
@@ -621,8 +620,7 @@ void hfs_bnode_put(struct hfs_bnode *noddprint (DBG_BNODE_REFS ,"put_node(%d:%d): %d\n" , node->tree->cnid, node->this,atomic_read (&node->refcnt)); -if (!atomic_read (&node->refcnt)) -BUG (); +BUG_ON (!atomic_read (&node->refcnt));if (!atomic_dec_and_lock (&node->refcnt, &tree->hash_lock))return ;for (i =0 ; i < tree->pages_per_bnode; i++) {
fs/hfsplus/btree.c renamed from fs/hfsplus/btree.c.orig +1 -2
@@ -268,8 +268,7 @@ void hfs_bmap_free(struct hfs_bnode *nodu8 *data, byte, m;dprint (DBG_BNODE_MOD ,"btree_free_node: %u\n" , node->this); -if (!node->this) -BUG (); +BUG_ON (!node->this); tree = node->tree; nidx = node->this; node =hfs_bnode_find (tree,0 );
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors