Skip to contentSkip to conversation

BUG_ON() Conversion in fs/sysv/

PATCH New Eric Sesterhenn / snakebyte 1 participant 1 message Jan 27, 2006 Kernel janitors

lore
Share & tools
lore

Eric Sesterhenn / snakebyte

author
#0 lore raw

PATCH 10/12 BUG_ON() Conversion in fs/sysv/

hi,

this changes if() BUG(); constructs to BUG_ON() which is cleaner, contains unlikely() and can better optimized away.

Signed-off-by Eric Sesterhenn <[email protected]>
fs/sysv/dir.c renamed from fs/sysv/dir.c.orig +2 -4
@@ -253,8 +253,7 @@ int sysv_delete_entry(struct sysv_dir_en
 
 	lock_page(page);
 	err = mapping->a_ops->prepare_write(NULL, page, from, to);
-	if (err)
-		BUG();
+	BUG_ON(err);
 	de->inode = 0;
 	err = dir_commit_chunk(page, from, to);
 	dir_put_page(page);

@@ -353,8 +352,7 @@ void sysv_set_link(struct sysv_dir_entry
 
 	lock_page(page);
 	err = page->mapping->a_ops->prepare_write(NULL, page, from, to);
-	if (err)
-		BUG();
+	BUG_ON(err);
 	de->inode = cpu_to_fs16(SYSV_SB(inode->i_sb), inode->i_ino);
 	err = dir_commit_chunk(page, from, to);
 	dir_put_page(page);

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors