Skip to content Skip to conversation

BUG_ON() Conversion in kernel/cpu.c

PATCH New Eric Sesterhenn / snakebyte 1 participant 1 message Jan 30, 2006

Subsystems (2)

Kernel janitors CPU hotplug

Share & tools

Eric Sesterhenn / snakebyte

author

2006-01-30 21:15 UTC #0 lore raw

PATCH 1/6 BUG_ON() Conversion in kernel/cpu.c

hi,

this changes if() BUG(); constructs to BUG_ON() which is cleaner, contains unlikely() and can better optimized away.

Signed-off-by Eric Sesterhenn <[email protected]>

kernel/cpu.c renamed from kernel/cpu.c.orig +1 -2

@@ -223,8 +221,7 @@ int __devinit cpu_up(unsigned int cpu)
 	ret = __cpu_up(cpu);
 	if (ret != 0)
 		goto out_notify;
-	if (!cpu_online(cpu))
-		BUG();
+	BUG_ON(!cpu_online(cpu));
 
 	/* Now call notifier in preparation. */
 	notifier_call_chain(&cpu_chain, CPU_ONLINE, hcpu);

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors