BUG_ON() Conversion in mm/highmem.c
Subsystems (3)
PATCH 1/7 BUG_ON() Conversion in mm/highmem.c
hi,
this changes if() BUG(); constructs to BUG_ON() which is cleaner, contains unlikely() and can better optimized away.
Signed-off-by Eric Sesterhenn <[email protected]>
mm/highmem.c renamed from mm/highmem.c.orig +5 -10
@@ -83,8 +83,7 @@ static void flush_all_zero_pkmaps(void) pkmap_count[i] =0 ;/* sanity check */ -if (pte_none (pkmap_page_table[i])) -BUG (); +BUG_ON (pte_none (pkmap_page_table[i]));/* * Don't need an atomic fetch-and-clear op here;
@@ -167,8 +166,7 @@ void fastcall *kmap_high(struct page *paif (!vaddr) vaddr =map_new_virtual (page); pkmap_count[PKMAP_NR (vaddr)]++; -if (pkmap_count[PKMAP_NR (vaddr)] <2 ) -BUG (); +BUG_ON (pkmap_count[PKMAP_NR (vaddr)] <2 );spin_unlock (&kmap_lock);return (void *) vaddr; }
@@ -183,8 +181,7 @@ void fastcall kunmap_high(struct page *pspin_lock (&kmap_lock); vaddr = (unsigned long )page_address (page); -if (!vaddr) -BUG (); +BUG_ON (!vaddr); nr =PKMAP_NR (vaddr);/*
@@ -229,8 +226,7 @@ static __init int init_emergency_pool(voreturn 0 ; page_pool =mempool_create (POOL_SIZE , page_pool_alloc, page_pool_free,NULL ); -if (!page_pool) -BUG (); +BUG_ON (!page_pool);printk ("highmem bounce pool size: %d pages\n" ,POOL_SIZE );return 0 ;
@@ -272,8 +268,7 @@ int init_emergency_isa_pool(void)return 0 ; isa_page_pool =mempool_create (ISA_POOL_SIZE , page_pool_alloc_isa, page_pool_free,NULL ); -if (!isa_page_pool) -BUG (); +BUG_ON (!isa_page_pool);printk ("isa bounce pool size: %d pages\n" ,ISA_POOL_SIZE );return 0 ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors